Date: Wed, 29 Feb 2012 14:04:31 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: d@delphij.net Cc: freebsd-arch@freebsd.org Subject: Re: RFC: futimens(2) and utimensat(2) Message-ID: <20120229120431.GX55074@deviant.kiev.zoral.com.ua> In-Reply-To: <4F4DC876.3010809@delphij.net> References: <4F4DC876.3010809@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--3BXhlsXkTW/kybY4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 28, 2012 at 10:40:54PM -0800, Xin Li wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 >=20 > Hi, >=20 > These are required by IEEE Std 1003.1-2008. Patchset at: >=20 > http://people.freebsd.org/~delphij/for_review/utimens.diff The patch looks fine, I have only some stylistic comments. You misordered the functions both in Symbol.map and in the man page. The kern_utimensat() definition would benefit from making the second line of the function shorter then 80 columns. I suggest to use a local struct vnode *vp variable instead of dereferencing fp->f_vnode on each line. Put error and vfslocked declarations in kern_futimens on the same line. I do not see a need in having _SYS_SYSPROTO_H_ for new syscalls. We always do have sysproto.h. And, omiting the generated files from the patch would make it easier to rea= d. --3BXhlsXkTW/kybY4 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk9OFE8ACgkQC3+MBN1Mb4hykQCg27zu75p6Z/Uj4K7YlW6E6V0C NNoAn3RtY6vmZj1K61oVfOQuM6c5trM3 =O1m5 -----END PGP SIGNATURE----- --3BXhlsXkTW/kybY4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120229120431.GX55074>