Date: Sun, 7 Oct 2012 17:11:18 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Andriy Gapon <avg@freebsd.org> Cc: freebsd-hackers <freebsd-hackers@freebsd.org> Subject: Re: machine/cpu.h in userland Message-ID: <20121007141118.GW35915@deviant.kiev.zoral.com.ua> In-Reply-To: <507172DA.2020309@FreeBSD.org> References: <507172DA.2020309@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--CLy2MrvMHpW9mjhY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 07, 2012 at 03:17:30PM +0300, Andriy Gapon wrote: >=20 > I noticed that couple of our userland file include machine/cpu.h for no a= pparent > good reason. It looks like at least amd64 cpu.h has no userland servicea= ble > parts inside. > Maybe its content should be put under _KERNEL ? >=20 > Also: >=20 > --- a/sbin/adjkerntz/adjkerntz.c > +++ b/sbin/adjkerntz/adjkerntz.c > @@ -51,7 +51,6 @@ __FBSDID("$FreeBSD$"); > #include <syslog.h> > #include <sys/time.h> > #include <sys/param.h> > -#include <machine/cpu.h> > #include <sys/sysctl.h> >=20 > #include "pathnames.h" > diff --git a/usr.bin/w/w.c b/usr.bin/w/w.c > index 8441ce5..9674fc2 100644 > --- a/usr.bin/w/w.c > +++ b/usr.bin/w/w.c > @@ -57,7 +57,6 @@ static const char sccsid[] =3D "@(#)w.c 8.4 (Berkeley) = 4/16/94"; > #include <sys/socket.h> > #include <sys/tty.h> >=20 > -#include <machine/cpu.h> > #include <netinet/in.h> > #include <arpa/inet.h> > #include <arpa/nameser.h> Both proposals are obviously fine. Some research with git blame traces the include presence in the w.c to the 4.4 Lite import. What I do not understand is why do you spam lists instead of commmitting the obvious changes ? --CLy2MrvMHpW9mjhY Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAlBxjYYACgkQC3+MBN1Mb4gbZACgjj5XP4xZJPDVQkz/9t13TBA8 QDsAnR8v1n5IgnKkqOkgzq802v6pwA8m =e9Kw -----END PGP SIGNATURE----- --CLy2MrvMHpW9mjhY--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121007141118.GW35915>