Date: Mon, 11 Feb 2013 11:48:51 GMT From: Olivier Cochard-Labbe <olivier@cochard.me> To: freebsd-gnats-submit@FreeBSD.org Subject: kern/176027: flow control systcl consistency for em drivers Message-ID: <201302111148.r1BBmp8Q072978@red.freebsd.org> Resent-Message-ID: <201302111150.r1BBo25U091575@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 176027
>Category: kern
>Synopsis: flow control systcl consistency for em drivers
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Feb 11 11:50:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Olivier Cochard-Labbe
>Release: 9.1-RELEASE
>Organization:
BSD Router Project
>Environment:
>Description:
On my systems em(4) flow control can be configured with:
dev.em.0.fc (if chipset depends of if_em.c)
or
dev.em.0.flow_control (if chipset depends of if_lem.c)
For more consistency (but a POLA?), here is a small patch for if_lem.c that replace 'flow_control' usage by 'fc' usage.
>How-To-Repeat:
>Fix:
Applying the patch.
Patch attached with submission follows:
--- sys/dev/e1000/if_lem.c.orig 2013-02-11 10:21:00.000000000 +0100
+++ sys/dev/e1000/if_lem.c 2013-02-11 10:21:20.000000000 +0100
@@ -458,7 +458,7 @@
#endif
/* Sysctl for setting the interface flow control */
- lem_set_flow_cntrl(adapter, "flow_control",
+ lem_set_flow_cntrl(adapter, "fc",
"flow control setting",
&adapter->fc_setting, lem_fc_setting);
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201302111148.r1BBmp8Q072978>