Date: Wed, 08 Sep 2010 18:19:47 +0000 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: mdf@FreeBSD.org Cc: FreeBSD Arch <freebsd-arch@FreeBSD.org> Subject: Re: Extending sbufs with a drain Message-ID: <67571.1283969987@critter.freebsd.dk> In-Reply-To: Your message of "Wed, 08 Sep 2010 10:51:45 MST." <AANLkTikWhLUHMsY0iT7d1F27TUtx-xHQd5ZmzZhKBmGf@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <AANLkTikWhLUHMsY0iT7d1F27TUtx-xHQd5ZmzZhKBmGf@mail.gmail.com>, mdf@ FreeBSD.org writes: >> But I will always have this nagging doubt that we just added yet >> another deadbeat extension, rather than actually solve the >> actual problem. > >So just to clarify, what do you consider the actual problem? As I said: That we have worked around the problem rather than fixing it properly. I did a prototype somewhat along the lines of what you have done but abandonned it, because we would loose the printf argument checking that GCC provides. (See also the extensible userland printf I did). My main objection to your patches is that you exposes internals of sbufs for no good reason, if you fix that, along the lines we have discussed, I won't have that objection. Poul-Henning -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?67571.1283969987>