Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 07 Feb 2011 17:01:55 +0300
From:      Anonymous <swell.k@gmail.com>
To:        Pawel Jakub Dawidek <pjd@FreeBSD.org>
Cc:        freebsd-current@FreeBSD.org
Subject:   Re: Next ZFSv28 patchset ready for testing.
Message-ID:  <86lj1s3pv0.fsf@gmail.com>
In-Reply-To: <8662upxg76.fsf@gmail.com> (Anonymous's message of "Mon, 20 Dec 2010 06:42:53 %2B0300")
References:  <20101213214556.GC2038@garage.freebsd.pl> <8662upxg76.fsf@gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Anonymous <swell.k@gmail.com> writes:

> Pawel Jakub Dawidek <pjd@FreeBSD.org> writes:
>
>> The new patchset is ready for testing:
>>
>> 	http://people.freebsd.org/~pjd/patches/zfs_20101212.patch.bz2
>>
>
> `-e' option in zdb(8) now looks under /dev/dsk by default
>
>   $ zdb -ec blah
>
>   Configuration for import:
>           vdev_children: 1
>           version: 6
>           vdev_tree:
>               children[0]:
>                   phys_path: '/dev/gptid/A-B-C-D-E'
>                   path: '/dev/dsk/gptid/A-B-C-D-E'
>   zdb: can't open 'blah': No such file or directory
>   Exit 1

How about below diff then?

%%
--- cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c~
+++ cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c
@@ -1129,7 +1129,11 @@ zpool_find_import_impl(libzfs_handle_t *
 	char *end, **dir = iarg->path;
 	size_t pathleft;
 	nvlist_t *ret = NULL;
+#ifdef sun
 	static char *default_dir = "/dev/dsk";
+#else
+	static char *default_dir = "/dev";
+#endif
 	pool_list_t pools = { 0 };
 	pool_entry_t *pe, *penext;
 	vdev_entry_t *ve, *venext;
%%

>
>   $ zdb -p /dev -ec blah
>
>   Traversing all blocks to verify metadata checksums and verify nothing leaked ...
>   Assertion failed: (mp->initialized == B_TRUE), file /usr/src/cddl/lib/libzpool/../../../cddl/contrib/opensolaris/lib/libzpool/common/kernel.c, line 130.
>   Exit 134

I can't reproduce anymore, at least as of ch188544.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86lj1s3pv0.fsf>