Date: Wed, 17 Jan 2018 11:38:36 -0700 From: Adam Weinberger <adamw@adamw.org> To: =?utf-8?Q?Martin_Waschb=C3=BCsch?= <martin@waschbuesch.de> Cc: freebsd-ports@freebsd.org Subject: Re: Help with versioning scheme Message-ID: <931905FC-BD14-4F40-BFC4-4ACBDC887932@adamw.org> In-Reply-To: <D3D2C74D-DA67-4B8D-96C3-4E1E2928D815@waschbuesch.de> References: <F35F7011-4DDA-4BD4-93FB-BE75ECD49827@waschbuesch.de> <C655A3CB-8C52-4CB0-A6F4-F34EAD224175@adamw.org> <D3D2C74D-DA67-4B8D-96C3-4E1E2928D815@waschbuesch.de>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 17 Jan, 2018, at 11:29, Martin Waschbüsch <martin@waschbuesch.de> wrote: > > Hi Adam, >> Am 17.01.2018 um 19:19 schrieb Adam Weinberger <adamw@adamw.org>: >> Hi Martin, >> >> You don't want to use the upstream version to represent PORTREVISION. >> PORTREVISION is for when you need to force rebuilds of the port itself, >> and so tying it to upstream would make it impossible to bump it >> ourselves. >> >> Why do you need to ignore the fourth digit? It's perfectly valid for our >> purposes. > > So far, I had (because it coincided with their version number) used it to > provide SO_VER. But that breaks now: > > --- > # Created by: adamw > # $FreeBSD: head/archivers/liblz4/Makefile 448415 2017-08-20 12:30:25Z > sunpoet $ > > PORTNAME= lz4 > PORTVERSION= 1.8.1 > DISTVERSIONPREFIX= v > PORTEPOCH= 1 > CATEGORIES= archivers > PKGNAMEPREFIX= lib > > MAINTAINER= martin@waschbuesch.de > COMMENT= LZ4 compression library, lossless and very fast > > LICENSE= BSD2CLAUSE GPLv2 > LICENSE_COMB= multi > > USES= gmake pathfix pkgconfig > USE_GITHUB= yes > USE_LDCONFIG= yes > #PATHFIX_MAKEFILEIN= Makefile > > ALL_TARGET= default # don't remove this > SO_VER= ${PORTVERSION} > PLIST_SUB+= SO_VER=${SO_VER} SO_VER_MAJ=${SO_VER:R:R} > LIBDIR= ${PREFIX}/lib > > post-patch: > @${FIND} ${WRKSRC} -name Makefile | ${XARGS} ${REINPLACE_CMD} \ > -e '/^MANDIR :=/s|share/||' > @${REINPLACE_CMD} -e '/^all:/s/$$/ liblz4.pc/' \ > ${WRKSRC}/lib/Makefile > @${REINPLACE_CMD} -e '/^all:/s|fullbench.*||' \ > ${WRKSRC}/programs/Makefile > > post-install: > ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/lz4* > ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/liblz4.so.${SO_VER} > > .include <bsd.port.mk> > --- > > Manually specifying the SO_VER seems also very weird. > > I am sorry if these questions seem clumsy - I am not terribly experienced > with porting stuff, but eager to learn. You can still use them---just add an extra :R. PLIST_SUB+= SO_VER=${SO_VER:R} SO_VER_MAJ=${SO_VER:R:R} # Adam -- Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?931905FC-BD14-4F40-BFC4-4ACBDC887932>