Date: Thu, 10 Jun 2010 15:04:37 -0400 From: Alexander Sack <pisymbol@gmail.com> To: Jack Vogel <jfvogel@gmail.com> Cc: Juli Mallett <jmallett@freebsd.org>, freebsd-net@freebsd.org Subject: Re: Dual-rate transceivers with ixgbe? Message-ID: <AANLkTikjs42mE5QHnSvZ9x9DI1xfYowvIES-DRORz6hH@mail.gmail.com> In-Reply-To: <AANLkTikqjQic_M3mX7OTx-V0OJxbk4vzxajPmHmIUAKa@mail.gmail.com> References: <AANLkTinO9NZ8F9TeS68I2ULQgdlMGzlXkinCsywWosAM@mail.gmail.com> <AANLkTinS607kd3wc3F2WWmA6Zk9KL4GhscxEHPtcvxA5@mail.gmail.com> <AANLkTimkxOn9h6SAkTPDqfUM9kl2CZiFrZC_BuNDfRyB@mail.gmail.com> <AANLkTikcQMXk8UebmaynOeeInGiwx8yr0NMGE1yJfm8u@mail.gmail.com> <AANLkTil_YRvU54qHtIMO7mP4yYjojeHVrCHaRcl2K2Ug@mail.gmail.com> <AANLkTim5Ao9nSh6T6HF7NztLgvbTzxuVyr8lSXAJ7bMo@mail.gmail.com> <AANLkTim9-Za5mzLTw7MDAHY_TuIQsQ0SF0_1xpxyGY7v@mail.gmail.com> <AANLkTik-V2frmirwBLtg4RemdEVvPhUmVsOP7CqEkvUi@mail.gmail.com> <AANLkTikqjQic_M3mX7OTx-V0OJxbk4vzxajPmHmIUAKa@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--0016e64ccb969c81bb0488b1b1e4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Thu, Jun 10, 2010 at 1:58 PM, Jack Vogel <jfvogel@gmail.com> wrote: > I believe I've explained this once before. The limitation code is put in > explicitly > because its what we support and all we support, we know that some hardwar= e > out there will not work, some may. > > If you buy the hardware you would be wise to make sure you get what's > supported, > but please don't ask me how to hack around it or what it means when you h= ave > problems when you do.=A0=A0 In the first place I dont have the time, seco= nd, I > do not > have the hardware or means to test that, and finally I need to abide by w= hat > my > management tells me...=A0 you do all want me to keep my job yes? :) I certainly do Jack! LOL. However, would it be possible to please make this a kenv tunable in the driver? Its kinda stupid I have to recompile to add a SFP. It can certainly be an unsupported feature by you. Patch attached. Tested with CURRENT driver on a 7.2-amd64-release machine. If you set the tunable to 1, ixgbe loads without issue. If you leave it to zero (default), it will not attach to unsupported SFPs. I also added DEBUGOUT6 since it was missing and caused a compilation failure when I turned on in-driver debugging. What do you think? -aps --0016e64ccb969c81bb0488b1b1e4 Content-Type: application/octet-stream; name="ixgbe-sfp.patch" Content-Disposition: attachment; filename="ixgbe-sfp.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ga9yj5ox1 SW5kZXg6IGl4Z2JlLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gaXhnYmUuYwkocmV2aXNpb24gMjA4OTUwKQor KysgaXhnYmUuYwkod29ya2luZyBjb3B5KQpAQCAtMjg0LDYgKzI4NCwxMyBAQAogc3RhdGljIGlu dCBpeGdiZV9yeGQgPSBQRVJGT1JNX1JYRDsKIFRVTkFCTEVfSU5UKCJody5peGdiZS5yeGQiLCAm aXhnYmVfcnhkKTsKIAorLyogCisgKiBBbGxvdyBjb25maWd1cmF0aW9uIG9mIHVuc3VwcG9ydGVk IFNGUHMuICAKKyAqIFVzZSBhdCB5b3VyIG93biByaXNrLiAKKyAqLworaW50IGl4Z2JlX2FsbG93 X3Vuc3VwcG9ydGVkX3NmcCA9IDA7CitUVU5BQkxFX0lOVCgiaHcuaXhnYmUuYWxsb3dfdW5zdXBw b3J0ZWRfc2ZwIiwgJml4Z2JlX2FsbG93X3Vuc3VwcG9ydGVkX3NmcCk7CisKIC8qIEtlZXAgcnVu bmluZyB0YWIgb24gdGhlbSBmb3Igc2FuaXR5IGNoZWNrICovCiBzdGF0aWMgaW50IGl4Z2JlX3Rv dGFsX3BvcnRzOwogCkluZGV4OiBpeGdiZV9waHkuYwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBpeGdiZV9waHku YwkocmV2aXNpb24gMjA4OTUwKQorKysgaXhnYmVfcGh5LmMJKHdvcmtpbmcgY29weSkKQEAgLTQ5 LDYgKzQ5LDggQEAKIHN0YXRpYyBib29sIGl4Z2JlX2dldF9pMmNfZGF0YSh1MzIgKmkyY2N0bCk7 CiB2b2lkIGl4Z2JlX2kyY19idXNfY2xlYXIoc3RydWN0IGl4Z2JlX2h3ICpodyk7CiAKK2V4dGVy biBpbnQgaXhnYmVfYWxsb3dfdW5zdXBwb3J0ZWRfc2ZwOworCiAvKioKICAqICBpeGdiZV9pbml0 X3BoeV9vcHNfZ2VuZXJpYyAtIEluaXRzIFBIWSBmdW5jdGlvbiBwdHJzCiAgKiAgQGh3OiBwb2lu dGVyIHRvIHRoZSBoYXJkd2FyZSBzdHJ1Y3R1cmUKQEAgLTExMDYsNyArMTEwOCw4IEBACiAJCX0K IAogCQlpeGdiZV9nZXRfZGV2aWNlX2NhcHMoaHcsICZlbmZvcmNlX3NmcCk7Ci0JCWlmICghKGVu Zm9yY2Vfc2ZwICYgSVhHQkVfREVWSUNFX0NBUFNfQUxMT1dfQU5ZX1NGUCkpIHsKKwkJaWYgKCEo ZW5mb3JjZV9zZnAgJiBJWEdCRV9ERVZJQ0VfQ0FQU19BTExPV19BTllfU0ZQKSAmJiAKKwkJICAg IChpeGdiZV9hbGxvd191bnN1cHBvcnRlZF9zZnAgPT0gMCkpIHsKIAkJCS8qIE1ha2Ugc3VyZSB3 ZSdyZSBhIHN1cHBvcnRlZCBQSFkgdHlwZSAqLwogCQkJaWYgKGh3LT5waHkudHlwZSA9PSBpeGdi ZV9waHlfc2ZwX2ludGVsKSB7CiAJCQkJc3RhdHVzID0gSVhHQkVfU1VDQ0VTUzsKSW5kZXg6IGl4 Z2JlX29zZGVwLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gaXhnYmVfb3NkZXAuaAkocmV2aXNpb24gMjA4OTUw KQorKysgaXhnYmVfb3NkZXAuaAkod29ya2luZyBjb3B5KQpAQCAtNjcsNiArNjcsNyBAQAogCSNk ZWZpbmUgREVCVUdPVVQxKFMsQSkgICAgICBwcmludGYoUyAiXG4iLEEpCiAJI2RlZmluZSBERUJV R09VVDIoUyxBLEIpICAgIHByaW50ZihTICJcbiIsQSxCKQogCSNkZWZpbmUgREVCVUdPVVQzKFMs QSxCLEMpICBwcmludGYoUyAiXG4iLEEsQixDKQorCSNkZWZpbmUgREVCVUdPVVQ2KFMsQSxCLEMs RCxFLEYpICAgIHByaW50ZihTICJcbiIsQSxCLEMsRCxFLEYpCiAJI2RlZmluZSBERUJVR09VVDco UyxBLEIsQyxELEUsRixHKSAgcHJpbnRmKFMgIlxuIixBLEIsQyxELEUsRixHKQogI2Vsc2UKIAkj ZGVmaW5lIERFQlVHT1VUKFMpCg== --0016e64ccb969c81bb0488b1b1e4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTikjs42mE5QHnSvZ9x9DI1xfYowvIES-DRORz6hH>