Date: Sun, 25 Nov 2012 14:48:19 -0800 From: mdf@FreeBSD.org To: Niclas Zeising <zeising+freebsd@daemonic.se> Cc: Alexander Motin <mav@freebsd.org>, current@freebsd.org Subject: Re: panic: sbuf_trim makes no sense on sbuf 0xffffff82434d8898 with drain Message-ID: <CAMBSHm9Yyn42dn4C7=8Ft7TYAEY%2BcUpevq0CfbB1vfv7EhOsxg@mail.gmail.com> In-Reply-To: <50B29B07.20808@daemonic.se> References: <50B29B07.20808@daemonic.se>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Nov 25, 2012 at 2:26 PM, Niclas Zeising <zeising+freebsd@daemonic.se> wrote: > Hi! > I consistently get this panic while trying to boot a kernel build from > r243530. It happens when the entropy harvesting rc.d script starts. r243380 > worked fine, I haven't tested any revisions in between. Attached is the > backtrace from the kernel, as gotten by kgdb. The machine uses zfs as a > root pool, and there have been churn in this area. To my untrained eyes, > however, the issue seem related to hdaa.c. Please let me know if I can > provide any more information. r243530 added the new sysctl that is causing panic. I'm not sure why there's an sbuf_trim() call; there shouldn't be more than a few \n at the end. IMO the sbuf_trim() can be eliminated. Alternately, the panic check can be removed and we could allow sbuf_trim() to remove any un-emitted whitespace for an sbuf with drain. CC'ing mav@ who introduced the code. (I introduced sbuf drains). Thanks, matthew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMBSHm9Yyn42dn4C7=8Ft7TYAEY%2BcUpevq0CfbB1vfv7EhOsxg>