Date: Sun, 15 Feb 2004 14:44:06 +0000 (UTC) From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> To: FreeBSD current mailing list <current@freebsd.org> Cc: "Bjoern A. Zeeb" <bzeeb+freebsd@zabbadoz.net> Subject: TEST/REVIEW IPSEC cleanup / update Message-ID: <Pine.BSF.4.53.0402151415500.4375@e0-0.zab2.int.zabbadoz.net>
next in thread | raw e-mail | index | archive | help
Hi, I have extracted some patches from my patchset that clean up / update IPSEC code. I have saved them into smaller junks for easier review. Please review and take that parts you like. I am currently unsure what parts from the big FreeBSD IPSEC update have been merged back to KAME thus I am initially posting all here. Though I didn't test none of these should break FAST_IPSEC (hopefully). The patches: http://sources.zabbadoz.net/freebsd/patchset/10010-ipsec-netinet-ip-output.diff ! Description: remove IMHO unneccesarry key_spdacquire and ! add a "fast path" for error case http://sources.zabbadoz.net/freebsd/patchset/10011-ipsec-netinet6-nd6-nbr.diff ! Description: remove IPSEC specifica from file; no longer needed http://sources.zabbadoz.net/freebsd/patchset/10012-ipsec-ifdef-fastipsec.diff ! Description: IPSEC and FAST_IPSEC have the same internal API now; ! so merge these (IPSEC has an extra ipsecstat) http://sources.zabbadoz.net/freebsd/patchset/10013-ipsec-key-allocsp-tag.diff ! Description: remove unsued tag argument from functions http://sources.zabbadoz.net/freebsd/patchset/10014-ipsec-unused-code.diff ! Description: remove dead code http://sources.zabbadoz.net/freebsd/patchset/10015-ipsec-correct-panic-strings.diff ! Description: fix comments (still not using %s, __func__) http://sources.zabbadoz.net/freebsd/patchset/10016-ipsec-netkey-key-consolidate.diff ! Description: move duplicate code to function http://sources.zabbadoz.net/freebsd/patchset/10017-ipsec-netkey-key-key-spdadd-freesp.diff ! Description: key_msg2sp uses key_freesp so should we on its return value http://sources.zabbadoz.net/freebsd/patchset/10018-ipsec-comment-simplify.diff ! Description: + correct panic string (still not using %s, __func__) ! + set to NULL only if not NULL before; the if is there anyway http://sources.zabbadoz.net/freebsd/patchset/10019-ipsec-ipsec-comment.diff ! Description: correct panic string (still not using %s, __func__) -- Greetings Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT 56 69 73 69 74 http://www.zabbadoz.net/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.53.0402151415500.4375>