Date: Tue, 24 Feb 2015 14:26:36 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 197975] textproc/mgdiff take MAINTAINERship Message-ID: <bug-197975-13-UUrY5C2BCc@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-197975-13@https.bugs.freebsd.org/bugzilla/> References: <bug-197975-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D197975 --- Comment #4 from Chris Hutchinson <portmaster@bsdforge.com> --- (In reply to Jan Beich from comment #2) > Comment on attachment 153408 [details] > svn diff for textproc/mgdiff >=20 > > USES=3D imake motif > > USE_XORG=3D ice sm x11 xext xmu xp xt > >-SUB_FILES=3D pkg-message > >=20 > >+DESKTOP_ENTRIES=3D "mgdiff" "GUI front end to the UNIX diff command" \ > >+ "mgDIFF-48x48" \ > >+ "mgdiff" "GNOME;GTK;Motif;Development;System;" \ >=20 > Why the app is listed in GNOME and GTK categories but has no such > dependencies? It's just a standard template I use. No harm comes from listing them. No warnings will be emitted either. >=20 > >+WWW: http://BSDforge.com/projects/textproc/mgdiff/ >=20 > WWW doesn't match MASTER_SITES. Did you take upstream maintainership as w= ell? Upstream hasn't, to the best of my knowledge, *ever* provided a WWW. As a WWW wasn't provided in src, or the port, I felt others would benefit from having one. As to take upstream maintenance; I'm waiting to see if the original author expresses any objection (I've contacted him). >=20 > > post-install: > >- @${MKDIR} ${STAGEDIR}${PREFIX}/lib/X11/mgdiff > >- ${INSTALL_DATA} ${WRKSRC}/mgdiff.x[bp]m ${STAGEDIR}${PREFIX}/lib/X11/m= gdiff > >+ @${MKDIR} ${STAGEDIR}${PREFIX}/share/pixmaps > >+ ${CP} ${FILESDIR}/mgDIFF-48x48.xpm ${STAGEDIR}${PREFIX}/share/pixmaps/= mgDIFF-48x48.xpm >=20 > Why different case: mgDIFF vs. mgdiff? Cause it was easier for me to [visually] differentiate it. > share/pixmaps icons aren't themed, so > Icon=3Dmgdiff-48x48 in .desktop file won't match other colorless variants. > Here's a quick test for Gtk behavior via attachment 153255 [details] >=20 > $ icon-lookup > usage: icon-lookup icon_theme icon_name size flags >=20 > $ icon-lookup test mgdiff 0 0 > /usr/local/share/pixmaps/mgdiff.xpm > $ icon-lookup test mgdiff 48 0 > /usr/local/share/pixmaps/mgdiff.xpm >=20 > $ icon-lookup test mgdiff-48x48 0 0 > /usr/local/share/pixmaps/mgdiff-48x48.xpm > $ icon-lookup test mgdiff-48x48 48 0 > /usr/local/share/pixmaps/mgdiff-48x48.xpm Thanks! >=20 > >+ ${INSTALL_DATA} ${WRKSRC}/mgdiff.x[bp]m ${STAGEDIR}${PREFIX}/share/pix= maps >=20 > Note, XBM format isn't supported by Icon Theme spec (v0.11). And mgdiff.x= bm > is already embedded in the binary. >=20 > $ fgrep -r .xbm . > ./Makefile.ini:MISC =3D Makefile Imakefile mgdiff.xbm Mgdiff.ad > ./Makefile.ini:mgdiff.o : mgdiff.c mgdiff.h externs.h patchlevel.h > mgdiff.xbm > ./mgdiff.c:#include "mgdiff.xbm" I intended to incorporate the new colored one globally. But need to add more applications to the box I'm developing on, in order to create the SVG format I intend to use. The box I develop on is slated for an update [FreeBSD] so decided to wait until then, before adding the additional applications. The one I provided, will suffice during the [short] interim. Thanks for all your attention to this, Jan Beich. --Chris --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-197975-13-UUrY5C2BCc>