Date: Sat, 24 Oct 2015 04:58:42 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 203471] New port: editors/e The minimalistest text editor Message-ID: <bug-203471-13-Q2uuf1xdpE@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-203471-13@https.bugs.freebsd.org/bugzilla/> References: <bug-203471-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D203471 Jan Beich <jbeich@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |needs-qa --- Comment #2 from Jan Beich <jbeich@FreeBSD.org> --- (Hand over to danfe@ as "In Progress" is invalid without Assignee) Other than comment 1 there're lots of style bugs as well. $ portlint -AC FATAL: Makefile: [3]: use a tab (not space) after a variable name FATAL: Makefile: [4]: use a tab (not space) after a variable name FATAL: Makefile: [5]: use a tab (not space) after a variable name FATAL: Makefile: [6]: use a tab (not space) after a variable name FATAL: Makefile: [8]: use a tab (not space) after a variable name FATAL: Makefile: [9]: use a tab (not space) after a variable name FATAL: Makefile: [11]: use a tab (not space) after a variable name FATAL: Makefile: [12]: use a tab (not space) after a variable name FATAL: Makefile: [14]: use a tab (not space) after a variable name FATAL: Makefile: [15]: use a tab (not space) after a variable name FATAL: Makefile: [16]: use a tab (not space) after a variable name FATAL: Makefile: [18]: use a tab (not space) after a variable name FATAL: Makefile: [19]: use a tab (not space) after a variable name FATAL: Makefile: [20]: use a tab (not space) after a variable name WARN: Makefile: COMMENT should begin with a capital, and end without a peri= od 14 fatal errors and 1 warning found. >XPORTVERSION=3D 1.0 [...] >XGH_TAGNAME=3D 2dffcf1c7245142c8bfc813641a5467f6300bf08 Marking a random commit as 1.0 may lead you to bump PORTEPOCH in future if upstream create a tag with lower version e.g., 0.4. Better prepend a few ze= ros then use the date of the commit e.g., 0.0.20141210. >XDIST_SUBDIR=3D e This is not necessary as USE_GITHUB makes filenames unique enough, see distinfo. >XCOMMENT=3D e is the minimalistest text editor "e is the" should be dropped to avoid redundancy. >XUSE_GCC=3D yes USE_GCC is an implementation detail. Unless it doesn't build for a valid re= ason (e.g. bug in a compiler, another port or hard to fix) drop or convert to USES=3Dcompiler. Clang errors are often verbose enough to tell you how to f= ix them: e.c:84:1: warning: return type of 'main' is not 'int' [-Wmain-return-type] unsigned int main(register unsigned int argc, char* argv[]) { ^ e.c:84:1: note: change return type to 'int' unsigned int main(register unsigned int argc, char* argv[]) { ^~~~~~~~ int e.c:84:14: error: first parameter of 'main' (argument count) must be of t= ype 'int' unsigned int main(register unsigned int argc, char* argv[]) { ^ 1 warning and 1 error generated. >Xpost-extract: >X @${MV} ${WRKSRC}/makefile ${WRKSRC}/Makefile Define MAKEFILE instead. >Xpost-patch: >X @${REINPLACE_CMD} -e 's/gcc/${CC}/' ${WRKSRC}/Makefile Don't use / separator with variables that may contain paths. $ make CC=3D/usr/local/bin/clang37 =3D=3D=3D> Applying FreeBSD patches for e-1.0 sed: 1: "s/gcc//usr/local/bin/cl ...": bad flag in substitute command: 'u' *** Error code 1 >X+all: >X gcc ./e.c ./codes.c -o e No respect for CFLAGS/LDFLAGS/LIBS ? Either adjust above post-patch or repl= ace "all" target e.g., # Provides both "all" and "install" targets USES=3D uidfix MAKEFILE=3D /usr/share/mk/bsd.prog.mk MAKE_ENV=3D PROG=3D${PORTNAME} NO_MAN=3D BINDIR=3D"${PREFIX}/bin" \ SRCS=3D"`${ECHO_CMD} *.c`" https://www.freebsd.org/doc/en/books/porters-handbook/dads-cflags.html >X+ >X+install: all >X+ mkdir -p $(DESTDIR)$(PREFIX)/bin/ >X+ install -m 755 e $(DESTDIR)$(PREFIX)/bin/ >X+ If you don't plan to upstream "install" target then move installation into = the port. For one, it'd take care of stripping non-debug builds for you. https://www.freebsd.org/doc/en/books/porters-handbook/install.html#install-= strip --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-203471-13-Q2uuf1xdpE>