Date: Tue, 18 Oct 2016 13:20:01 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 213587] net-p2p/go-ethereum: Update to 1.4.18 Message-ID: <bug-213587-13-zp4SWAiptP@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-213587-13@https.bugs.freebsd.org/bugzilla/> References: <bug-213587-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D213587 --- Comment #3 from Kubilay Kocak <koobs@FreeBSD.org> --- (In reply to Fynn from comment #2) Having looked at Makefile and pkg-plist in the repository it looks OK (syntactically).=20 Having said that I'm not sure I would provide an option for every single binary, but that would depend on the size of the binaries and whether or not there was a good case to be made for 'most users only want to install a sub= set' based on a general/majority use-case. Points also go against the need for options for each one given: - None of the options require additional dependencies, or any build time changes. - None of the options are enabled by default, meaning the binary package of= the port has much less utility by default. I would also clarify some of the OPTIONS_DESC's. For example: BOOTNODE_DESC=3D Runs a bootstrap node for the Discovery Protocol BOOTNODE does not appear to 'run' a bootstrap node, but it does install ano= ther binary (unclear). Maybe something like "bootstrap(8): Node for the Discovery Protocol Perhaps its worth prefixing the binary name to all OPTION_DESC's like above. Also consider grouping all of these into a OPTIONS_GROUP=3DUTILITIES with a UTILITIES_DESC=3DOptional Tools/Utilities, so that is further clear what th= ey all are. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-213587-13-zp4SWAiptP>