Date: Sun, 10 Sep 1995 12:19:31 +0200 (MET DST) From: J Wunsch <j@uriah.heep.sax.de> To: nistler@millcomm.com Cc: FreeBSD-gnats-submit@FreeBSD.ORG, bugs@FreeBSD.ORG Subject: Re: misc/717: ft.c attach fail on my Mountain tape drive Message-ID: <199509101019.MAA01669@uriah.heep.sax.de> In-Reply-To: <199509011732.MAA00403@chaos.millcomm.com> from "John Nistler" at Sep 1, 95 12:32:46 pm
next in thread | previous in thread | raw e-mail | index | archive | help
As John Nistler wrote:
>
> [2: ft0: Mountain tape]
>
> >Description:
> When the ft.c code does the attach it uses polling in the
> ftintr_waiti(in the if (ft->attach), in case FTCMD_SEEK) with a
> delay(100) which is too short. I changed this to 1000.
> >Fix:
>
> /usr/src/sys/i386/isa> diff ft.c.orig ft.c
> 1480c1480,1481
> < DELAY(100);
> ---
> > DELAY(1000);
> > /* DELAY(100); */
Please, supply context diffs! It's rather hard to track simple diffs
if the source has been changed meanwhile.
In this case, the entire logic has been slightly modified since 2.0R,
where your patch apparently is for. Can you please try if the
following patch would also solve your problem? This is the
appropriate code fragment out of 2.0.5. If this does solve it, too,
we can close the PR.
Index: ft.c
===================================================================
RCS file: /home/cvs/src/sys/i386/isa/ft.c,v
retrieving revision 1.14
diff -u -r1.14 ft.c
--- 1.14 1994/11/15 14:34:42
+++ ft.c 1995/09/10 10:14:32
@@ -1469,15 +1503,16 @@
case FTCMD_RECAL:
case FTCMD_SEEK:
for (retries = 0; retries < 10000; retries++) {
+ DELAY(150);
out_fdc(fdcu, NE7CMD_SENSEI);
st0 = in_fdc(fdcu);
+ if ((st0 & 0xc0) == 0x80) continue;
pcn = in_fdc(fdcu);
if (st0 & 0x20) {
ft->sts_wait = FTSTS_INTERRUPT;
ft->pcn = pcn;
goto intrdone;
}
- DELAY(100);
}
break;
}
--
cheers, J"org
joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/
Never trust an operating system you don't have sources for. ;-)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199509101019.MAA01669>