Date: Sun, 20 May 2001 14:02:09 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: sobomax@FreeBSD.org Cc: nik@FreeBSD.org, audit@FreeBSD.org, arch@FreeBSD.org Subject: Re: Integrating new scrshot(1) utility into vidcontrol(1) [patch for review] Message-ID: <20010520140209.C3338@sunbay.com> In-Reply-To: <200105182342.f4INgJx36064@mail.uic-in.net>; from sobomax@mail-in.net on Sat, May 19, 2001 at 02:42:28AM %2B0300 References: <200105182342.f4INgJx36064@mail.uic-in.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, May 19, 2001 at 02:42:28AM +0300, Maxim Sobolev wrote:
> Ok, as it was agreed I've integrated scrshot(1) into
> vidcontrol(1) and also added ability to dump contents
> of display buffer in plain text format, so you don't
> even need a special utility to see what's going on
> on a console of display-less machine. :-)
>
> Please somebody review attached patches (esp. manpage).
> Thank you!
>
> -Maxim
>
> Index: vidcontrol.1
> ===================================================================
> RCS file: /home/ncvs/src/usr.sbin/vidcontrol/vidcontrol.1,v
> retrieving revision 1.34
> diff -d -u -r1.34 vidcontrol.1
> --- vidcontrol.1 2001/04/18 15:51:56 1.34
> +++ vidcontrol.1 2001/05/18 23:32:37
> @@ -36,6 +36,8 @@
> .Op Fl M Ar char
> .Op Fl m Cm on | off
> .Op Fl r Ar foreground Ar background
> +.Op Fl p
> +.Op Fl P
> .Op Fl s Ar number
> .Op Fl t Ar N | Cm off
> .Op Fl x
>
Sort these (put them before `r').
> @@ -185,6 +187,21 @@
> Used together with the
> .Xr moused 8
> daemon for text mode cut & paste functionality.
> +.It Fl p
> +Capture the current contents of the video buffer corresponding
> +to the terminal device referred to by standard input.
> +.Nm
> +writes contents of the video buffer to the standard
> +output in a raw binary format. For details about that
^^
Always start a new sentence with a new line. Don't even use two
spaces (though it's valid). Using two spaces, while technically
speaking is right, complicates verifying of the document.
Often, two spaces are put by mistake, and produce weird results.
Always starting a new sentence with a new line significantly helps
to debug such problems, not to say to a) speed up the proccessing
and b) save the disk space.
> +.Ss Format of Video Buffer Dump
>
If assume this hunk was simply copied from the original manpage,
so it doesn't need a review.
> .Sh SEE ALSO
> .Xr kbdcontrol 1 ,
> .Xr vidfont 1 ,
> @@ -339,5 +468,13 @@
> .Xr rc.conf 5 ,
> .Xr kldload 8 ,
> .Xr moused 8
> +.Xr watch 8
>
Missing comma after "Xr moused 8".
> .Sh AUTHORS
> .An S\(/oren Schmidt Aq sos@FreeBSD.org
>
I think Nik deserves the credits here.
> @@ -70,8 +75,8 @@
> fprintf(stderr, "%s\n%s\n%s\n%s\n",
> "usage: vidcontrol [-r fg bg] [-b color] [-c appearance] [-d] [-l scrmap]",
> " [-i adapter | mode] [-L] [-M char] [-m on|off]",
> -" [-f size file] [-s number] [-t N|off] [-x] [-g geometry]",
> -" [mode] [fgcol [bgcol]] [show]");
> +" [-f size file] [-s number] [-t N|off] [-x] [-g geometry]",
> +" [-p] [-P] [mode] [fgcol [bgcol]] [show]");
> exit(1);
> }
Similarly, sort this.
Cheers,
--
Ruslan Ermilov Oracle Developer/DBA,
ru@sunbay.com Sunbay Software AG,
ru@FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010520140209.C3338>