Date: Sun, 04 Feb 2001 00:35:29 -0800 From: Peter Wemm <peter@netplex.com.au> To: Greg Lehey <grog@lemis.com> Cc: Robert Watson <rwatson@FreeBSD.ORG>, freebsd-current@FreeBSD.ORG, freebsd-hackers@FreeBSD.ORG Subject: Re: Watch your devfs permissions in driver make_dev calls Message-ID: <200102040835.f148ZTt19389@mobile.wemm.org> In-Reply-To: <20010204115741.G27504@sydney.worldwide.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Greg Lehey wrote: > On Friday, 2 February 2001 at 20:10:10 -0800, Peter Wemm wrote: > > Robert Watson wrote: > > > >> crw-r--r-- 1 root wheel 78, 0 Dec 31 1969 pci > > > > This one may appear harmless, but it is not. It is trivially easy to creat e > > an alignment fault (fatal on an alpha) with the userland pciconf tool. > > We must not allow this to be used by users until the kernel part is fixed. > > > > Eg: try this on an alpha: pciconf -r -l pci0:x:x 0x3 - ie: read a longword > > at byte offset 3 in configuration space.. kaboom! > > This looks like a separate issue. Presumably you can do this as root > as well. pciconf should check the parameters. The kernel should check the parameters passed in from the userland, at least, it should not die like this. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200102040835.f148ZTt19389>