Date: Sun, 24 Nov 2002 21:37:23 -0800 From: Kirk McKusick <mckusick@beastie.mckusick.com> To: Julian Elischer <julian@elischer.org> Cc: fs@freebsd.org Subject: Re: ufs types Message-ID: <200211250537.gAP5bN59067917@beastie.mckusick.com> In-Reply-To: Your message of "Fri, 22 Nov 2002 16:48:03 PST." <Pine.BSF.4.21.0211221642100.15030-100000@InterJet.elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Date: Fri, 22 Nov 2002 16:48:03 -0800 (PST) From: Julian Elischer <julian@elischer.org> To: fs@freebsd.org cc: mckusick@mckusick.com Subject: ufs types X-ASK-Info: Whitelist match We had a system on site today that fell over every time re tried to boot it. Causing delays in probably many millions of dollars of transfers. The reason was a currupt word in the cylinder group summary information. a word had been trashed becoming -ve, and fsck didn't check against -ve numbers in that (a rotor value). Noticing that most fields are not checked against being -ve in fsck we started looking at fixing it.. until we realised that the far quicker answer was to define them to be unsigned in ufs.h and just fix the compile errors.. The values are usually checked for reasonable +ve values. Does anyone have a reason why we should not do this in FreeBSD? (fix the superblock and cg summary blocks to have mostly unsigned values..) julian Your approved request should fix this problem. Kirk McKusick To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-fs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200211250537.gAP5bN59067917>