Date: Sun, 12 Jan 2003 00:10:06 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: Jake Burkholder <jake@locore.ca> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern kern_acl.c kern_descrip.c kern_event.c kern_mac.c sys_pipe.c sys_socket.c uipc_socket.c uipc_syscalls.c uipc_usrreq.c vfs_aio.c vfs_syscalls.c vfs_vnops.c src/sys/netgraph ng_socket.c src/sys/sys file.h src/sys/ufs/ffs ... Message-ID: <200301120810.h0C8A6PL067502@apollo.backplane.com> References: <200301120137.h0C1bD0E098037@repoman.freebsd.org> <20030111213259.E212@locore.ca> <200301120254.h0C2srcS043241@apollo.backplane.com> <20030112014644.F212@locore.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
:Its unnecessary code churn. I wouldn't be surprised if struct file was
:used all the place in 3rd party modules, especially MAC modules. Now
:they either need an ugly compat define or ugly idfefs. Some of your commits
:were to code that's externally maintained. We've broken compatibility with
:external code before for compelling reasons. This is not a compelling reason.
:
:You obviously don't think this is important, I do. If no one else cares about
:this I'll shut up now.
:
:Jake
Well, I certainly do not think this is important for the reasons
you state. This is a 10 second source-level fix for a 3rd party.
ABI compatibility is maintained, and this whole thing amounts to a tiny
little hicup in regards to 3rd party compatibility compared to the
API and ABI disruption that occurs every time someone removes a little
bit more of Giant. Unless you are advocating that we stop moving forward
on SMP also, that is. Direct API changes are the easiest to synchronize
to. Indirect locking changes are far more difficult.
I do believe it is important to clean code up. I believe that cleanly
implemented and well documented code has a far larger long term
positive impact then the minor API disruptions it might cause. So,
yes, my priorities for -current are probably a bit different then yours.
That does not invalidate them.
-Matt
Matthew Dillon
<dillon@backplane.com>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200301120810.h0C8A6PL067502>