Date: Sun, 12 Jan 2003 12:07:18 +0100 From: <jrf@subdimension.com> To: freebsd-hardware@freebsd.org Subject: Inconsistency in SMBus drivers? Message-ID: <20030112111342.1EFAE43EB2@mx1.FreeBSD.org>
next in thread | raw e-mail | index | archive | help
Hi,
while trying to use the ichsmb driver, I noticed something odd: in
ichsmb.c, the slave address is always shifted, while the other drivers
(e.g. amdpm.c) take the slave address as given.
Here is an example from ichsmb.c:
int
ichsmb_bread(device_t dev, u_char slave, char cmd, u_char count, char *buf)
{
(...)
bus_space_write_1(sc->io_bst, sc->io_bsh, ICH_XMIT_SLVA,
(slave << 1) | ICH_XMIT_SLVA_READ);
and the corresponding lines from amdpm.c:
static int
amdpm_bread(device_t dev, u_char slave, char cmd, u_char count, char *buf)
{
(...)
AMDPM_SMBOUTW(sc, AMDSMB_HSTADDR, slave | LSB);
Oh, and why is ichsmb under src/sys/dev, while the others are unders
src/sys/pci?
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hardware" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030112111342.1EFAE43EB2>