Date: Sat, 24 Sep 2005 18:36:49 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: nate@root.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, phk@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys bus.h rman.h types.h src/sys/kern subr_bus.c Message-ID: <20050924.183649.76052067.imp@bsdimp.com> In-Reply-To: <4335D760.9080007@root.org> References: <20050924193119.F1A8A16A448@hub.freebsd.org> <4335D760.9080007@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <4335D760.9080007@root.org>
Nate Lawson <nate@root.org> writes:
: Poul-Henning Kamp wrote:
: > --- src/sys/sys/bus.h:1.71 Sun Sep 18 01:32:09 2005
: > +++ src/sys/sys/bus.h Sat Sep 24 19:31:10 2005
: > @@ -85,11 +85,6 @@
: > const char *__type, const char *__data);
: > void devctl_queue_data(char *__data);
: >
: > -/*
: > - * Forward declarations
: > - */
: > -typedef struct device *device_t;
: > -
: > /**
: > * @brief A device driver (included mainly for compatibility with
: > * FreeBSD 4.x).
:
: > diff -u src/sys/sys/types.h:1.92 src/sys/sys/types.h:1.93
: > --- src/sys/sys/types.h:1.92 Tue May 31 15:18:17 2005
: > +++ src/sys/sys/types.h Sat Sep 24 19:31:10 2005
: > @@ -285,6 +285,7 @@
: > typedef __uintfptr_t uintfptr_t;
: > typedef __uint64_t uoff_t;
: > typedef struct vm_page *vm_page_t;
: > +typedef struct device *device_t;
: >
: > #define offsetof(type, field) __offsetof(type, field)
:
: I don't think our device_t definition belongs in sys/types.h. It is
: opaque for a reason.
It is still opaque.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050924.183649.76052067.imp>