Date: Sat, 30 Dec 2006 16:53:19 -0800 From: Julian Elischer <julian@elischer.org> To: Yar Tikhiy <yar@comp.chem.msu.su> Cc: Max Laier <max@love2party.net>, Andre Oppermann <andre@freebsd.org>, freebsd-net@freebsd.org Subject: Re: [was] addition to ipfw (read vlans from bridge).. Message-ID: <459709FF.30205@elischer.org> In-Reply-To: <20061230173053.GB94532@comp.chem.msu.su> References: <457DCD47.5090004@elischer.org> <200612120045.41425.max@love2party.net> <4583119B.20608@elischer.org> <200612160446.02644.max@love2party.net> <4584CE0C.3020307@elischer.org> <458C426A.9060604@elischer.org> <20061224093951.GD49045@comp.chem.msu.su> <459032EA.1030601@elischer.org> <20061226061610.GD81280@comp.chem.msu.su> <4591A2D3.50708@elischer.org> <20061230173053.GB94532@comp.chem.msu.su>
next in thread | previous in thread | raw e-mail | index | archive | help
Yar Tikhiy wrote: > However, I have one question regarding "etype", please see below. > >> Index: netinet/ip_fw2.c >> + /* >> + * if we have an ether header, >> + */ >> + if (args->eh) >> + etype = (ntohs(args->eh->ether_type)) == ETHERTYPE_VLAN; > > And here we assign a boolean value to etype. Is it intended? > Looks like a error to me. Apparently it should read: > > etype = ntohs(args->eh->ether_type); > good catch!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?459709FF.30205>