Date: Sat, 24 Nov 2007 17:44:26 -0700 From: John Hein <jhein@timing.com> To: Roman Divacky <rdivacky@freebsd.org> Cc: emulation@freebsd.org, des@freebsd.org Subject: Re: compat/linprocfs Message-ID: <18248.50538.142360.921846@gromit.timing.com> In-Reply-To: <20071124221946.GA74651@freebsd.org> References: <20071124221946.GA74651@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Roman Divacky wrote at 23:19 +0100 on Nov 24, 2007:
> in
> compat/linprocfs/linprocfs.c:linprocfs_doprocmaps() there's
>
> unsigned int last_timestamp;
>
> variable declaration, this variable is used only once in this function:
>
> if (last_timestamp + 1 != map->timestamp) {
>
> ie. the map->timestamp is compared to some stack garbage + 1. this does not
> seem to be correct, the last_timestamp must be set somewhere..
>
> comments?
It is set 6 lines earlier...
last_timestamp = map->timestamp;
vm_map_unlock_read(map);
error = uiomove(mebuffer, len, uio);
vm_map_lock_read(map);
if (error)
break;
if (last_timestamp + 1 != map->timestamp) {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?18248.50538.142360.921846>