Date: Fri, 19 Sep 2008 01:06:48 +0400 From: Stanislav Sedov <stas@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: Rui, Paulo <rpaulo@freebsd.org>, freebsd-drivers@freebsd.org, Pyun YongHyeon <yongari@freebsd.org> Subject: Re: [Review request]: Attansic L2 ethernet driver Message-ID: <20080919010648.2b1ca962.stas@FreeBSD.org> In-Reply-To: <200809081456.56064.jhb@freebsd.org> References: <20080831222822.76d4ee92.stas@FreeBSD.org> <200809081456.56064.jhb@freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, 8 Sep 2008 14:56:55 -0400 John Baldwin <jhb@freebsd.org> mentioned: > A few style notes: > - return (FILTER_STRAY) (missing ()'s) > - Extra indentation for one of the TASK_INIT()'s > - Are you using 4 space indent or 8 space indent? > Thanks! Pyun YongHyeon also gave a lot of comments on code, so I'm working on fixing these. My indentation is standard one: one tab for 1st level indents, and four spaces for second. -- Stanislav Sedov ST4096-RIPE [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkjSwu8ACgkQK/VZk+smlYGDaACePv+8ZLSEzUwDQpKgvE4ZyFAb IDUAnja6q0yH8wJW51DJAZXkFsoebyUU =ExVq -----END PGP SIGNATURE-----help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080919010648.2b1ca962.stas>