Date: Sat, 20 Jun 2009 22:12:06 -0400 (EDT) From: Pete Carah <pete@altadena.net> To: FreeBSD-gnats-submit@FreeBSD.org Subject: kern/135874: Geom_linux_lvm misses newer fedora defaults Message-ID: <200906210212.n5L2C6KG001064@port4.altadena.net> Resent-Message-ID: <200906210300.n5L30Hnn060078@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 135874
>Category: kern
>Synopsis: Geom_linux_lvm misses newer fedora defaults
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Jun 21 03:00:17 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Pete Carah
>Release: FreeBSD 7.2-STABLE amd64
>Organization:
Altadena Internet
>Environment:
System: FreeBSD port4.altadena.net 7.2-STABLE FreeBSD 7.2-STABLE #2 r194560M: Sat Jun 20 21:50:58 EDT 2009 pete@port4.altadena.net:/usr/obj/usr/src/sys/PORT47 amd64
>Description:
Geom doesn't derive the correct name for default logical volumes
in the default fedora 11 layout, which are named lv_root and lv_swap. The
problem is that isalpha doesn't include underscore.
>How-To-Repeat:
Try to mount a linux lvm whose name contains an underscore.
>Fix:
--- g_linux_lvm.c (revision 194560)
+++ g_linux_lvm.c (working copy)
@@ -828,7 +828,8 @@
#define GRAB_NAME(tok, name, len) \
len = 0; \
- while (tok[len] && (isalpha(tok[len]) || isdigit(tok[len])) && \
+ while (tok[len] && (isalpha(tok[len]) || isdigit(tok[len]) || \
+ tok[len] == '_' ) && \
len < G_LLVM_NAMELEN - 1) \
len++; \
bcopy(tok, name, len); \
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200906210212.n5L2C6KG001064>