Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 25 Jul 2010 18:40:15 +0400
From:      Anonymous <swell.k@gmail.com>
Cc:        freebsd-current@FreeBSD.org
Subject:   Re: BSD grep fixes
Message-ID:  <86ocdv7hqk.fsf@gmail.com>
In-Reply-To: <4C4BFC04.8080503@FreeBSD.org> (Gabor Kovesdan's message of "Sun,  25 Jul 2010 10:55:32 %2B0200")
References:  <4C4BFC04.8080503@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
(the message didn't get into the list because of silly typo: `cuirrent@'
instead of `current@')

Gabor Kovesdan <gabor@FreeBSD.org> writes:

> I've fixed the last two issues that were reported. If you encounter
> something more, please let me know.

Thanks. But I think there is another issue affecting usr.bin/kdump/mkioctls.

  $ make depend
  sh /usr/src/usr.bin/kdump/mkioctls /usr/include > ioctl.c
  <stdin>:1:31: fatal error: altq/altq.h:#define: No such file or directory
  compilation terminated.
  sh /usr/src/usr.bin/kdump/mksubr /usr/include > kdump_subr.c
  rm -f .depend
  mkdep -f .depend -a    -I/usr/src/usr.bin/kdump/../ktrace -I/usr/src/usr.bin/kdump -I/usr/src/usr.bin/kdump/../.. /usr/src/usr.bin/kdump/kdump.c ioctl.c kdump_subr.c /usr/src/usr.bin/kdump/../ktrace/subr.c
  ioctl.c:26:31: fatal error: altq/altq.h:#define: No such file or directory
  compilation terminated.
  mkdep: compile failed
  *** Error code 1

  Stop in /usr/src/usr.bin/kdump.

If I reduce to a simple case it would look like following

  $ echo blah >foo
  $ echo clop >bar
  $ bsd-grep -l '.*' ./*
  ./foo:blah
  ./foo
  ./bar:clop
  ./bar
  $ gnu-grep -l '.*' ./*
  ./foo
  ./bar

`-l' option is not supposed to show the matching line at all, only filename.

>
> Gabor
>
> -------- Mensagem Original --------
> Assunto: svn commit: r210461 - head/usr.bin/grep
>    Data: Sun, 25 Jul 2010 08:42:18 +0000 (UTC)
>      De: Gabor Kovesdan <gabor@FreeBSD.org>
>    Para: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
>
> Author: gabor
> Date: Sun Jul 25 08:42:18 2010
> New Revision: 210461
> URL: http://svn.freebsd.org/changeset/base/210461
>
> Log:
>   - Fix --color behaviour to only output color sequences if stdout is a tty
>     or if forced mode is specified [1]
>   - While here, add some alternative names for the options and make then
>     case-insensitive
>   - Fix -q and -l behaviour [2]
>   - Some small changes to make the code easier to review
>
>   Submitted by:   swell.k@gmail.com [1],
>                   dougb [2]
>   Approved by:    delphij (mentor)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86ocdv7hqk.fsf>