Date: Sat, 9 Oct 2010 17:54:38 -0700 From: Gordon Tetlow <gordon@tetlows.org> To: jhell <jhell@dataix.net> Cc: FreeBSD Ports <ports@freebsd.org> Subject: Re: devel/p4d/Makefile Message-ID: <AANLkTimCjEzpEVTS85m%2B2icpm5Z1gv%2BKRP5MYDL5PknV@mail.gmail.com> In-Reply-To: <4CAB3A64.4080709@DataIX.net> References: <4CAB3A64.4080709@DataIX.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 5, 2010 at 7:47 AM, jhell <jhell@dataix.net> wrote:
> Hi Gordon,
>
> I have just upgraded my p4d install and have found the following
> inconsistency in the Makefile:
>
> ${CAT} pkg-message
>
> pkg-message at this point cannot be found and it would be better if this
> referred to the ports directory and the portname /pkg-message instead.
>
>
> I might also suggest that instead of using touch(1) chown(1) chmod(1) to
> create entries in the filesystem for the p4d.log that you use install(1)
> instead as that allows you to achieve all three steps listed above in
> one command like so.
>
> install -S -o p4admin -g p4admin -m 640 /dev/null /var/log/p4d.log
>
> And of course this might need/involve some checking to see if the users
> log file already exists as we would not want to overwrite that by the
> above command but nor do we want to blindly chmod(1) the file either
> which is also done in the Makefile already.
A lot of the existing code was taken from the previous version of the
port. I didn't mess with it particularly when I took it over. I'll
take a look at the pkg-message part. At the very least, I should be
able to change it to ${PKGMESSAGE}.
Gordon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTimCjEzpEVTS85m%2B2icpm5Z1gv%2BKRP5MYDL5PknV>