Date: Sat, 23 Oct 2010 20:26:41 -0700 From: Garrett Cooper <gcooper@FreeBSD.org> To: rc@freebsd.org Subject: Re: [PATCH] /etc/rc.d/mdconfig improvements Message-ID: <AANLkTikozJqrZtcZZ3Eop7AJ2QdsOxA0hYs4_XxpFjbv@mail.gmail.com> In-Reply-To: <AANLkTikEmEJ1fGAQWC_nFk0-DU6kY0hWSqq39YvBAeHN@mail.gmail.com> References: <AANLkTikEmEJ1fGAQWC_nFk0-DU6kY0hWSqq39YvBAeHN@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--0016e65684beb6be1504935471ec
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
On Sun, Oct 10, 2010 at 8:48 PM, Garrett Cooper <gcooper@freebsd.org> wrote=
:
> Hi RC folks,
> =A0 =A0I was looking at /etc/rc.d/mdconfig* recently, and I thought of
> two improvements that could be done to the scripts:
> =A0 =A01. It's not overly intuitive from the rc.conf manpage that the
> memory disks need to be defined in /etc/fstab, so I added an error to
> coach people on what to do
> =A0 =A02. There was also a missing guard for around a ${_file} reference
> where if I did...
>
> /dev/md0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0/scratch =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0cd9660 =A0 =A0 rw
> =A0 =A00 =A0 =A0 =A0 0
> /dev/md1 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0/scratch2 =A0 =A0 =A0 =A0 =A0 =A0=
=A0ufs =A0 =A0 rw =A0 =A0 =A0 =A0 =A0 =A0 =A00 =A0 =A0 =A0 0
>
> mdconfig_md0=3D"-f /scratch/disk.img -t vnode"
> mdconfig_md1=3D"-t swap -s 1M"
>
> =A0 =A0... it would check test for ${_file} twice and fail the second
> time. The check is benign in most cases, but for completeness it
> should be fixed as shown above.
> =A0 =A0Could someone please commit the attached patch for me, if no one
> objects to the change proposed?
(Resending with a .patch extension just in case)
Does anyone have any comments about the attached patch?
Thanks!
-Garrett
--0016e65684beb6be1504935471ec
Content-Type: text/x-patch; charset=US-ASCII;
name="etc-rc.d-mdconfig-improvements.patch"
Content-Disposition: attachment;
filename="etc-rc.d-mdconfig-improvements.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_gfnctvly1
SW5kZXg6IGV0Yy9yYy5kL21kY29uZmlnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGV0Yy9yYy5kL21kY29uZmln
CShyZXZpc2lvbiAyMTM2ODApCisrKyBldGMvcmMuZC9tZGNvbmZpZwkod29ya2luZyBjb3B5KQpA
QCAtMTQ2LDYgKzE0Niw4IEBACiAJCQlpZiBtb3VudCAtZCAke19kZXZ9IDI+JjEgPi9kZXYvbnVs
bDsgdGhlbgogCQkJCWVjaG8gIk1vdW50aW5nICR7X2Rldn0uIgogCQkJCW1vdW50ICR7X2Rldn0K
KwkJCWVsc2UKKwkJCQllcnIgMSAiTW91bnRwb2ludCBmb3IgJHtfZGV2fSBub3QgZGVmaW5lZCBp
biAvZXRjL2ZzdGFiIgogCQkJZmkKIAkJZmkKIAlkb25lCkluZGV4OiBldGMvcmMuZC9tZGNvbmZp
ZzIKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gZXRjL3JjLmQvbWRjb25maWcyCShyZXZpc2lvbiAyMTM2ODApCisr
KyBldGMvcmMuZC9tZGNvbmZpZzIJKHdvcmtpbmcgY29weSkKQEAgLTExMyw5ICsxMTMsMTEgQEAK
IAogCWZvciBfbWQgaW4gJHtfbWRjb25maWcyX2xpc3R9OyBkbwogCQlpbml0X3ZhcmlhYmxlcyAk
e19tZH0KLQkJaWYgWyAhIC1yICR7X2ZpbGV9IF07IHRoZW4KLQkJCWVyciAzICIke19maWxlfSBk
b2Vzbid0IGV4aXN0IgotCQkJY29udGludWUKKwkJaWYgWyAiJHt0eXBlfSIgPSAidm5vZGUiIF07
IHRoZW4KKwkJCWlmIFsgISAtciAiJHtfZmlsZX0iIF07IHRoZW4KKwkJCQllcnIgMyAiJHtfZmls
ZX0gZG9lc24ndCBleGlzdCIKKwkJCQljb250aW51ZQorCQkJZmkKIAkJZmkKIAkJIyBGaXJzdCBw
YXNzOiBjcmVhdGUgbWQoNCkgdm5vZGUgZGV2aWNlcyBmcm9tIGZpbGVzIHN0b3JlZCBvbgogCQkj
IG5vbi1yb290IHBhcnRpdGlvbi4gU3dhcCBhbmQgbWFsbG9jIG1kKDQpIGRldmljZXMgaGF2ZSBh
bHJlYWR5Cg==
--0016e65684beb6be1504935471ec--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTikozJqrZtcZZ3Eop7AJ2QdsOxA0hYs4_XxpFjbv>