Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 12 Sep 2010 00:03:38 +0000
From:      mdf@FreeBSD.org
To:        Alexander Kabaev <kan@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r212478 - head/sys/kern
Message-ID:  <AANLkTikgzNrak%2BLi0Xj0wrjBOeVvpX7e_md1wuxEDT0H@mail.gmail.com>
In-Reply-To: <201009111942.o8BJgocS032974@svn.freebsd.org>
References:  <201009111942.o8BJgocS032974@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Sep 11, 2010 at 7:42 PM, Alexander Kabaev <kan@freebsd.org> wrote:
> Author: kan
> Date: Sat Sep 11 19:42:50 2010
> New Revision: 212478
> URL: http://svn.freebsd.org/changeset/base/212478
>
> Log:
> =A0Add missing pointer increment to sbuf_cat.
>
> Modified:
> =A0head/sys/kern/subr_sbuf.c
>
> Modified: head/sys/kern/subr_sbuf.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sys/kern/subr_sbuf.c =A0 Sat Sep 11 18:55:00 2010 =A0 =A0 =A0 =
=A0(r212477)
> +++ head/sys/kern/subr_sbuf.c =A0 Sat Sep 11 19:42:50 2010 =A0 =A0 =A0 =
=A0(r212478)
> @@ -441,7 +441,7 @@ sbuf_cat(struct sbuf *s, const char *str
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return (-1);
>
> =A0 =A0 =A0 =A0while (*str !=3D '\0') {
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 sbuf_put_byte(*str, s);
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 sbuf_put_byte(*str++, s);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (s->s_error !=3D 0)
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return (-1);
> =A0 =A0 =A0 =A0}

D'oh!  Yeah, this looks right.  I guess the sbuf functions that ran
when I tested didn't use sbuf_cat.

Sorry,
matthew



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTikgzNrak%2BLi0Xj0wrjBOeVvpX7e_md1wuxEDT0H>