Date: Sat, 17 Sep 2011 22:19:27 -0400 From: "b. f." <bf1783@googlemail.com> To: Juergen Lock <nox@jelal.kn-bremen.de>, freebsd-multimedia@FreeBSD.org Cc: gerald@FreeBSD.org Subject: Re: Has anyone tested the jack update - am I ok to commit it? Message-ID: <CAGFTUwNMqpOcYLZCzbZ7tj5qqZF6UXm6zv-%2BH3ZxYNa9U9VQCA@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > This port is maintained by this list (multimedia@) so I thought > I better ask once more before committing... :) The update is > here: > > http://people.freebsd.org/~nox/tmp/jack-0.120.1.patch > > and I first mentioned it in this thread: > > http://lists.freebsd.org/pipermail/freebsd-multimedia/2011-September/012432.html > > (Using a midi keyboard with FreeBSD (jack update, ardour3 alpha...)) While I understand you have already invested some time in testing this, I don't think it would be wise to update only to 0.120.1 -- the latest release is 0.121.2, and the release notes for 0.120.2 and subsequent releases mention not only significant enhancements, but some important bug-fixes, e.g.: "Fix issues with stack initialization in client threads that stole large chunks of the stack from applications", "Fix memory overrun when calling jack_get_ports() with arguments that lead it to return all existing ports", "Remove client->control->nframes data element and use control->engine->buffer_size. This fixes erroneous behaviour when trying to get the buffer size associated with JACK port type", ... Also, please consider merging the following changes in yours: -- clean up ugly flag handling -- make the building of the HTML documentation an OPTION, off-by-default -- the doxygen dependency, which by default drags in many Python, graphviz, TeX, and Qt4 dependencies, is too heavy a burden for package builders and testers, and it was never a good idea to require it in order to build a small audio server. (These changes could be replaced by packaging the documents in a separate, locally-mirrored tarball, or, provided that the port is kept up-to-date, by downloading them from the master site.) b. [-- Attachment #2 --] Index: Makefile =================================================================== RCS file: /home/pcvs/ports/audio/jack/Makefile,v retrieving revision 1.60 diff -u -r1.60 Makefile --- Makefile 11 Aug 2011 19:19:01 -0000 1.60 +++ Makefile 18 Sep 2011 00:57:10 -0000 @@ -21,9 +21,10 @@ celt0.2:${PORTSDIR}/audio/celt LATEST_LINK= jack -CONFIGURE_ENV= LIBS="${PTHREAD_LIBS}" LDFLAGS="-L${LOCALBASE}/lib" \ - CPPFLAGS="-I${LOCALBASE}/include" \ - CFLAGS="${CFLAGS} ${PTHREAD_CFLAGS}" +CFLAGS+= ${PTHREAD_CFLAGS} +CPPFLAGS+= -I${LOCALBASE}/include +LDFLAGS+= -L${LOCALBASE}/lib +CONFIGURE_ENV= LIBS="${PTHREAD_LIBS}" LDFLAGS="${LDFLAGS}" CONFIGURE_ARGS+=--enable-portaudio \ --with-default-tmpdir=/tmp GNU_CONFIGURE= yes @@ -33,14 +34,17 @@ MAN1= jackd.1 jackstart.1 -OPTIONS= ALSA "Build with ALSA compatibility library" off +OPTIONS= ALSA "Build with ALSA compatibility library" off \ + DOCS "Build HTML documents (requires doxygen)" off .include <bsd.port.pre.mk> -.if !defined(NOPORTDOCS) +.if defined(WITH_DOCS) && !defined(NOPORTDOCS) BUILD_DEPENDS+= doxygen:${PORTSDIR}/devel/doxygen +PLIST_SUB+= DOCS="" .else CONFIGURE_ENV+= ac_cv_prog_HAVE_DOXYGEN="false" +PLIST_SUB+= DOCS="@comment " .endif .if exists(${LOCALBASE}/lib/libreadline.so.6) Index: pkg-plist =================================================================== RCS file: /home/pcvs/ports/audio/jack/pkg-plist,v retrieving revision 1.24 diff -u -r1.24 pkg-plist --- pkg-plist 16 Dec 2010 17:34:13 -0000 1.24 +++ pkg-plist 18 Sep 2011 00:58:09 -0000 @@ -53,75 +53,75 @@ lib/libjackserver.so lib/libjackserver.so.0 libdata/pkgconfig/jack.pc -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/annotated.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/classes.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/deprecated.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/doxygen.css -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/doxygen.png -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/files.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/fsm.png -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/functions.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/functions_vars.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_0x65.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_0x69.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_0x6a.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_0x6d.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_0x6f.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_0x70.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_0x73.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_0x74.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_defs.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_enum.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_eval.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_func.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_type.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/globals_vars.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/group__ClientCallbacks.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/group__ClientFunctions.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/group__ClientThreads.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/group__ErrorOutput.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/group__MIDIAPI.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/group__NonCallbackAPI.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/group__PortFunctions.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/group__PortSearching.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/group__ServerControl.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/group__TimeFunctions.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/group__TransportControl.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/index.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/inprocess_8c.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/intclient_8h.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/intclient_8h_source.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/jack_8h.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/jack_8h_source.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/mainpage_8dox.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/midiport_8h.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/midiport_8h_source.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/modules.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/pages.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/porting-guide.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/porting_8dox.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/ringbuffer_8h.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/ringbuffer_8h_source.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/simple__client_8c.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/statistics_8h.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/statistics_8h_source.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/struct__jack__midi__event.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/structjack__position__t.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/structjack__ringbuffer__data__t.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/structjack__ringbuffer__t.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/structjack__transport__info__t.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/structport__pair__t.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/thread_8h.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/thread_8h_source.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/transport-design.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/transport_8dox.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/transport_8h.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/transport_8h_source.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/types_8h.html -%%PORTDOCS%%share/jack-audio-connection-kit/reference/html/types_8h_source.html -%%PORTDOCS%%@dirrm share/jack-audio-connection-kit/reference/html -%%PORTDOCS%%@dirrm share/jack-audio-connection-kit/reference -%%PORTDOCS%%@dirrm share/jack-audio-connection-kit +%%DOCS%%share/jack-audio-connection-kit/reference/html/annotated.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/classes.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/deprecated.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/doxygen.css +%%DOCS%%share/jack-audio-connection-kit/reference/html/doxygen.png +%%DOCS%%share/jack-audio-connection-kit/reference/html/files.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/fsm.png +%%DOCS%%share/jack-audio-connection-kit/reference/html/functions.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/functions_vars.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_0x65.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_0x69.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_0x6a.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_0x6d.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_0x6f.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_0x70.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_0x73.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_0x74.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_defs.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_enum.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_eval.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_func.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_type.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/globals_vars.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/group__ClientCallbacks.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/group__ClientFunctions.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/group__ClientThreads.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/group__ErrorOutput.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/group__MIDIAPI.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/group__NonCallbackAPI.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/group__PortFunctions.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/group__PortSearching.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/group__ServerControl.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/group__TimeFunctions.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/group__TransportControl.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/index.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/inprocess_8c.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/intclient_8h.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/intclient_8h_source.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/jack_8h.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/jack_8h_source.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/mainpage_8dox.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/midiport_8h.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/midiport_8h_source.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/modules.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/pages.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/porting-guide.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/porting_8dox.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/ringbuffer_8h.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/ringbuffer_8h_source.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/simple__client_8c.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/statistics_8h.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/statistics_8h_source.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/struct__jack__midi__event.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/structjack__position__t.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/structjack__ringbuffer__data__t.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/structjack__ringbuffer__t.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/structjack__transport__info__t.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/structport__pair__t.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/thread_8h.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/thread_8h_source.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/transport-design.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/transport_8dox.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/transport_8h.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/transport_8h_source.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/types_8h.html +%%DOCS%%share/jack-audio-connection-kit/reference/html/types_8h_source.html +%%DOCS%%@dirrm share/jack-audio-connection-kit/reference/html +%%DOCS%%@dirrm share/jack-audio-connection-kit/reference +%%DOCS%%@dirrm share/jack-audio-connection-kit @dirrm lib/jack @dirrm include/jack
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGFTUwNMqpOcYLZCzbZ7tj5qqZF6UXm6zv-%2BH3ZxYNa9U9VQCA>