Date: Sat, 21 Jan 2012 23:29:16 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Nikos Vassiliadis <nvass@gmx.com> Cc: freebsd-net@freebsd.org Subject: Re: STP id selection Message-ID: <CAJ-VmomXDbjj=-8ztjZT-7ODhiRq%2Bz%2B9PiKfR5i7XOzUjGMvCQ@mail.gmail.com> In-Reply-To: <4F1ABF9C.5010608@gmx.com> References: <4F1ABF9C.5010608@gmx.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21 January 2012 05:37, Nikos Vassiliadis <nvass@gmx.com> wrote: > Hi, > > The current code in bridgestp.c finds the lower MAC address from all > available ethernets and uses it as the STP id. This is problematic when > more than one STP bridges participate in the same STP domain because > more than one bridges will use the same id. A similar fix was applied > to the OpenBSD version of the code[1]. Could you review the attached > patch? > > 1.http://www.openbsd.org/cgi-**bin/cvsweb/src/sys/net/** > bridgestp.c?rev=1.33<http://www.openbsd.org/cgi-bin/cvsweb/src/sys/net/bridgestp.c?rev=1.33>; > > Thanks, Nikos > > .. that sounds sensible enough. Sure, please create a PR and then tell me what the ID is. I keep finding myself knee deep in the bridge code so this is something I can test out locally. Adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmomXDbjj=-8ztjZT-7ODhiRq%2Bz%2B9PiKfR5i7XOzUjGMvCQ>