Date: Sun, 4 Nov 2012 11:47:11 +0100 From: Hans Petter Selasky <hselasky@c2i.net> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: freebsd-usb@freebsd.org Subject: Re: RFC: new USB quirk Message-ID: <201211041147.11076.hselasky@c2i.net> In-Reply-To: <5D9BFA84-4B90-4769-BE02-F771C3AE5441@xcllnt.net> References: <5D9BFA84-4B90-4769-BE02-F771C3AE5441@xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday 03 November 2012 22:42:33 Marcel Moolenaar wrote:
> Hans,
>
> Juniper has a few products that use STmicro USB-NAND controllers
> (the ST72682 in particular) and they really don't like the SCSI
> command for prevent/allow medium removal. The attached patch
> adds a quirk for this to avoid spamming the console with errors
> or warnings.
>
> Does it look good to you?
> Ok to commit?
>
> Thanks,
Hi,
You also need to update this table in usb_quirk.c:
static const char *usb_quirk_str[USB_QUIRK_MAX] = {
[UQ_NONE] = "UQ_NONE",
Can you do that and send a new patch for review?
--HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201211041147.11076.hselasky>