Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 10 Jun 2012 02:28:23 GMT
From:      John Baldwin <jhb@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 212551 for review
Message-ID:  <201206100228.q5A2SNZG019775@skunkworks.freebsd.org>

next in thread | raw e-mail | index | archive | help

http://p4web.freebsd.org/@@212551?ac=10

Change 212551 by jhb@jhb_fiver on 2012/06/10 02:27:40

	Fix locking bogon.

Affected files ...

.. //depot/projects/fadvise/sys/kern/vfs_subr.c#11 edit

Differences ...

==== //depot/projects/fadvise/sys/kern/vfs_subr.c#11 (text+ko) ====

@@ -1352,12 +1352,12 @@
 		error = BUF_TIMELOCK(bp,
 		    LK_EXCLUSIVE | LK_SLEEPFAIL | LK_INTERLOCK, BO_MTX(bo),
 		    "detachbuf", slpflag, slptimeo);
-		if (error != ENOLCK)
-			return (error);
-		if (error == EAGAIN) {
+		if (error == ENOLCK) {
 			BO_LOCK(bo);
 			goto restart;
 		}
+		if (error)
+			return (error);
 		KASSERT(bp->b_bufobj == bo,
 		    ("bp %p wrong b_bufobj %p should be %p",
 		    bp, bp->b_bufobj, bo));



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201206100228.q5A2SNZG019775>