Date: Sat, 5 May 2012 20:15:54 -0700 (PDT) From: Doug Barton <dougb@FreeBSD.org> To: Bruce Evans <brde@optusnet.com.au> Cc: Baptiste Daroussin <bapt@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@FreeBSD.org>, Garrett Cooper <yanegomi@gmail.com>, "svn-src-all@freebsd.org" <svn-src-all@FreeBSD.org>, "svn-src-head@freebsd.org" <svn-src-head@FreeBSD.org>, "kmoore@freebsd.org" <kmoore@FreeBSD.org>, Josh Paetzel <jpaetzel@FreeBSD.org> Subject: Re: svn commit: r235005 - head/usr.sbin/pc-sysinstall/backend Message-ID: <alpine.BSF.2.00.1205052013560.62374@bcgv.qbhto.arg> In-Reply-To: <20120505192318.T1202@besplex.bde.org> References: <201205041531.q44FVaYF010236@svn.freebsd.org> <F68AFF89-B9C3-494B-8B61-7130999BC354@gmail.com> <20120504182200.GD1604@azathoth.lan> <4FA438C4.3080701@FreeBSD.org> <20120505192318.T1202@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 5 May 2012, Bruce Evans wrote:
> On Fri, 4 May 2012, Doug Barton wrote:
>
>> On 05/04/2012 11:22 AM, Baptiste Daroussin wrote:
>>>>>>> fetch -s "${FETCHFILE}" >${SIZEFILE}
>>>>>>> SIZE="`cat ${SIZEFILE}`"
>>>>>>> - SIZE="`expr ${SIZE} / 1024`"
>>>>>>> + SIZE=$((SIZE/1024))
>>>>>
>>>>> Bug; should be '$SIZE/'
>>> No this is perfectly valid
>>
>> Yes, that works, but it's not our usual style. However, the point is
>> moot as that whole block should be reduced down to:
>>
>> SIZE=$(( `fetch -s "${FETCHFILE}"` / 1024 ))
>
> The KNF rule that there shall be spaces around binary operators should
> probably apply in shell expressions too, but I don't like the spaces
> on 1 side of (( and )). Shell syntax doesn't even allow spaces between
> '$' ((.
The "extra" spaces there are a personal style thing. I do it for 2
reasons, readability primarily, but also to distinguish arithmetic
operations from $(command) style.
> The rc.d style seems to be to use backquotes and not use $(cmd), but I
> prefer the opposite except possibly in shell expressions like the above
> so that it is easier to separate the commands from the shell expressions.
Yeah, backticks over $() is also a personal style issue, for no
particular good reason other than "looks better to me." :)
Doug
--
It's always a long day; 86400 doesn't fit into a short.
Breadth of IT experience, and depth of knowledge in the DNS.
Yours for the right price. :) http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1205052013560.62374>