Date: Sun, 8 Dec 2013 12:09:08 +0800 (SGT) From: Patrick Dung <patrick_dkt@yahoo.com.hk> To: Greg Lewis <glewis@eyesbeyond.com>, Albert Shih <Albert.Shih@obspm.fr> Cc: "freebsd-java@freebsd.org" <freebsd-java@freebsd.org> Subject: Re: 7u45 update - amd64 testers Message-ID: <1386475748.12996.YahooMailNeo@web193502.mail.sg3.yahoo.com> In-Reply-To: <20131207193105.GA17749@misty.eyesbeyond.com> References: <20131207064044.GA79133@misty.eyesbeyond.com> <20131207092231.GA51378@pcjas.obspm.fr> <20131207190545.GA87007@misty.eyesbeyond.com> <20131207193105.GA17749@misty.eyesbeyond.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, December 8, 2013 3:31 AM, Greg Lewis <glewis@eyesbeyond.com> wro= te:=0AOn Sat, Dec 07, 2013 at 11:05:45AM -0800, Greg Lewis wrote:=0A> On Sa= t, Dec 07, 2013 at 10:22:31AM +0100, Albert Shih wrote:=0A> >=A0 Le 06/12/2= 013 ? 22:40:44-0800, Greg Lewis a ?crit=0A> > > Can someone please download= =0A> > > =0A> > > http://people.freebsd.org/~glewis/openjdk7-7u45.diff=0A>; = > > =0A> > > and see if it compiles on amd64?=A0 If it does I'll go ahead a= nd commit it.=0A> > > Already tested on i386 locally.=0A> > =0A> > No that'= s not compiles.=0A> > =0A> > On :=0A> > =0A> >=A0 =A0 9.2-STABLE FreeBSD 9= .2-STABLE #11 r258722: Thu Nov 28 23:37:54 CET 2013 =0A> > =0A> >=A0 =A0 k= ernel=A0 /usr/obj/usr/src/sys/GENERIC=A0 amd64=0A> > =0A> > all ports is up= 2date.=0A> > =0A> > Here the logs.=0A> > =0A> > Thanks for your work.=0A> = =0A> Thanks Albert.=A0 That actually looks like a 8.x vs. 9.x problem.=A0 I= t needs=0A> to be fixed regardless.=0A> =0A> On 8.x:=0A> =0A> typedef struc= t sem *=A0 =A0 sem_t;=0A> =0A> On 10.x (and presumably 9.x as well based on= the error)=0A> =0A> typedef struct _sem=A0 =A0 sem_t;=0A> =0A> I think th= e solution is to vary the os_semaphore_t definition in os_bsd.cpp=0A> based= on the FreeBSD version.=A0 Let me test compiling that on 8.x and I'll=0A> = send it out.=0A=0AActually, maybe it's as simple as this.=A0 Can someone gi= ve the following a=0Atry on a 9.x machine?=A0 Preferably amd64 since I stil= l want to make sure=0Awe're ok there.=0A=0Adiff -r 54995aa29dbb src/os/bsd/= vm/os_bsd.cpp=0A--- a/src/os/bsd/vm/os_bsd.cpp=A0=A0=A0 Wed Dec 04 22:06:37= 2013 -0800=0A+++ b/src/os/bsd/vm/os_bsd.cpp=A0=A0=A0 Sat Dec 07 11:29:16 2= 013 -0800=0A@@ -2755,7 +2755,11 @@=0A=A0 =A0 os_semaphore_t _semaphore;=0A= };=0A=0A+#if defined(__FreeBSD__) && __FreeBSD__ > 8=0A+Semaphore::Semaphor= e() : _semaphore() {=0A+#else=0ASemaphore::Semaphore() : _semaphore(0) {=0A= +#endif=0A=A0 SEM_INIT(_semaphore, 0);=0A}=0A=0A-- =0AGreg Lewis=A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Email=A0 : glewis@eyesbeyond.c= om=0AEyes Beyond=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Web=A0 =A0= : http://www.eyesbeyond.com/=0AInformation Technology=A0 =A0 =A0 =A0 =A0 = =A0 =A0 FreeBSD : glewis@FreeBSD.org=0A____________________________________= _=0A=0A=0AHi Greg,=0A=0AI could not patch the files using your last diff (I= was using cat file | patch -u -p6)=0AAnyway, I have maually edited os_bsd.= cpp:=0A=0A#if defined(__FreeBSD__) && __FreeBSD__ > 8=0ASemaphore::Semaphor= e() : _semaphore() {=0A#else=0A#Semaphore::Semaphore() : _semaphore(0) {=0A= #endif=0A=A0 SEM_INIT(_semaphore, 0);=0A}=0A=0A=0AIt compiled on my Freebsd= 9.2 x64.=0A=0AI tried to start my jvm application and seems fine.=0A=0ATha= nks and regards,=0APatrick Dung
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1386475748.12996.YahooMailNeo>