Date: Mon, 21 Oct 2013 12:56:03 +0200 From: Jan Henrik Sylvester <me@janh.de> To: pkg-list freebsd <freebsd-pkg@freebsd.org> Cc: Bryan Drewery <bdrewery@FreeBSD.org> Subject: Re: pkg shlib -R and -P swapped Message-ID: <52650843.2020203@janh.de> In-Reply-To: <525541B2.5040507@janh.de> References: <525541B2.5040507@janh.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/09/2013 13:44, Jan Henrik Sylvester wrote: > With pkg-1.1.4_7, "pkg shlib -P libx264.so.136" displays "libx264.so.136 > is linked to by the following packages:"... > > "pkg shlib -P" should be "pkg shlib -R" and vice versa. > > shlib.c has the logic backwards: "!provides_only" leads to > "pkgs_providing_lib". > > The patch attached fixes it. bdrewery@ just told me that the patch did not make it through the list. (It is always had to know, which lists allow attachments and which do not.) Here is patch-pkg__shlib.c inline in hope that my email program does not change any characters or line breaks: --- pkg/shlib.c~ 2013-07-06 12:48:19.000000000 +0200 +++ pkg/shlib.c 2013-10-09 13:28:42.000000000 +0200 @@ -175,10 +175,10 @@ retcode = pkgdb_open(&db, PKGDB_DEFAULT); - if (retcode == EPKG_OK && !provides_only) + if (retcode == EPKG_OK && !requires_only) retcode = pkgs_providing_lib(db, libname); - if (retcode == EPKG_OK && !requires_only) + if (retcode == EPKG_OK && !provides_only) retcode = pkgs_requiring_lib(db, libname); if (retcode != EPKG_OK) If this is not readable, I will put it on a webpage next time. > Cheers, > Jan Henrik
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52650843.2020203>