Date: Sat, 26 Jan 2013 19:40:14 -0500 From: Adam Weinberger <adamw@adamw.org> To: Jason Helfman <jgh@FreeBSD.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, Marcus von Appen <mva@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r311004 - head/devel/rbenv Message-ID: <10D8E274-1457-47AE-9971-3DC4DDBA4A75@adamw.org> In-Reply-To: <CAMuy=%2Bjt5cU6SN%2BomKMtAsoHaWuQyMLTXq5KyjLvwVjL%2Bq6Ggg@mail.gmail.com> References: <201301261106.r0QB61l8070374@svn.freebsd.org> <CAMuy=%2Bgw=BaoZQ2_7nhVX7OBk=Lv29ym4McziuVCVhOiWwsizA@mail.gmail.com> <E0FDED6D-4F1F-408E-95A7-B313BFF983EA@adamw.org> <CAMuy=%2Bjt5cU6SN%2BomKMtAsoHaWuQyMLTXq5KyjLvwVjL%2Bq6Ggg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2013-01-26, at 17:31, Jason Helfman <jgh@FreeBSD.org> wrote:
> On Sat, Jan 26, 2013 at 8:27 AM, Adam Weinberger <adamw@adamw.org> =
wrote:
>=20
>=20
> On 2013-01-26, at 10:18, Jason Helfman <jgh@FreeBSD.org> wrote:
>=20
>> On Sat, Jan 26, 2013 at 3:06 AM, Marcus von Appen <mva@freebsd.org> =
wrote:
>> +%%DATADIR%%/completions/rbenv.bash
>> +%%DATADIR%%/completions/rbenv.zsh
>> +@dirrm %%DATADIR%%/completions
>> +@dirrm %%DATADIR%%
>>=20
>>=20
>> IMHO shouldn't completions be tied into the OPTIONS framework and be =
conditional installed as other ports?
>>=20
>> -jgh
>=20
> This port doesn't install completions in the bash or zsh completion =
bundle dirs. it installs it in its own DATADIR, leaving it up to the =
user to copy or symlink to it from the proper location. We don't need an =
OPTION for everything under the sun.
>=20
> # Adam
>=20
> Fair enough. I haven't seen it done this way yet, but I also haven't =
dug the tree for an example comparison.
Standardizing locations for completions could be a good thing, for this =
exact reason. ${ZSH,BASH,TCSH}_COMPLETION_DIR in bsd.port.mk could be =
helpful.
# Adam
--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?10D8E274-1457-47AE-9971-3DC4DDBA4A75>