Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 26 Jan 2014 00:21:07 -0800
From:      Garrett Cooper <yaneurabeya@gmail.com>
To:        Jilles Tjoelker <jilles@stack.nl>
Cc:        Julio Merino <julio@meroh.net>, freebsd-testing@FreeBSD.org
Subject:   Re: [PATCH] convert /bin/sh tests over to ATF
Message-ID:  <EAAF62C6-DEFE-48A0-B77C-74174BF66796@gmail.com>
In-Reply-To: <20140124162759.GB90996@stack.nl>
References:  <B5290C1B-F262-479C-8D4F-A5D8B3CE5A52@gmail.com> <20140124162759.GB90996@stack.nl>

next in thread | previous in thread | raw e-mail | index | archive | help
On Jan 24, 2014, at 8:27 AM, Jilles Tjoelker <jilles@stack.nl> wrote:

> On Mon, Jan 20, 2014 at 08:44:58AM -0800, Garrett Cooper wrote:
>> Also, I added some functionality so the tests expect failures on
>> certain versions of FreeBSD due to missing functionality or
>> conformance modifications (see the .valid_osreldate files).
>=20
> I think this part is a bit too simplistic and inflexible. I have =
always
> dealt with changes affecting the tests by MFCing the changes to the
> tests along with the changes to sh itself, and this has worked well
> enough. On the other hand, I also run -current's sh and tests on my
> -stable machine, without installing the tests (and often also without
> installing the new sh). Therefore, the osreldate of the machine does =
not
> imply that the sh is also of that version.
>=20
> There are also changes like r222684 that need an adjustment to the =
tests
> which are hard to handle properly using a .valid_osreldate file.

Fair enough. Long story short, when I wrote this I was still working at =
EMC on a FreeBSD port project where we were porting =
revision-by-revision, so in order for the tests to not fail [so much], =
it helped to write in these checks. I agree though, this shouldn=92t hit =
mainline FreeBSD at all (will yank it).

> There may be some point in marking tests that are supposed to work on
> any POSIX-compliant sh and ones that are inherently FreeBSD-specific, =
or
> possibly more granular. However, this would be most useful when =
someone
> who cares about another sh implementation works on it.

Ok.

Thanks!
-Garrett=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EAAF62C6-DEFE-48A0-B77C-74174BF66796>