Date: Fri, 5 Dec 2014 19:59:47 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: jenkins-admin@freebsd.org Cc: FreeBSD CURRENT <freebsd-current@freebsd.org>, FreeBSD toolchain <freebsd-toolchain@freebsd.org> Subject: Re: Build failed in Jenkins: Build-UFS-image #599 Message-ID: <D290A7DA-0AED-4810-A1B1-470E35542292@gmail.com> In-Reply-To: <1052304530.8.1417827164793.JavaMail.jenkins@jenkins-9.freebsd.org> References: <1052304530.8.1417827164793.JavaMail.jenkins@jenkins-9.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Dec 5, 2014, at 16:52, jenkins-admin@freebsd.org wrote: > See <https://jenkins.freebsd.org/job/Build-UFS-image/599/>; I’m not entirely sure why the "could not determine COMPILER_TYPE" error popped up, but I have a couple of questions/concerns related to the makefile snippet. 1. Does it make sense to check CC when running make install? 2. Why isn’t this value determined once in Makefile.inc1 (per build phase), then passed down from there (I’ve already considered the scenario where someone explicitly sets CC in a non-toplevel Makefile, which is a problem, but an outlier rather than the norm)? AFAICT, it gets recomputed for every recursive make, which contributes to useless forking for something that honestly doesn’t change all that often/at all. At EMC/Isilon at least, we set CC/CXX=false when running make distribute*/installkernel/installworld to catch logic errors with rebuilding code. Should this be in FreeBSD? Thanks! PS I filed https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195732 to track this issue and resolve the problem. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUgn8zAAoJEMZr5QU6S73e4kMH/05XYNb9gTZbiOkcWMSvLch+ 3pYT6/Ti7l7ga0F5Y4ULYvmSINeos3fwoXAHzAPIUtvJDj896OtVpBRRiccgCFwC i29n3Mm5s064dZOsgueG3DiGix0RKkOLFqm6AXCVUL7wNtWZMDzHZCIJxYlx9yp8 KHY9fDj66llFqgEl3qFCB8I3u33CSIq/XSdb1U6KT2+pQusG5Dt8BuVptf4TbKUd PHjAU3KhTjla21UN1lBD261A3N7gi7sUnZZzpIK1WrnjpTUMGSU32qdALDqLQgvl 7MRlvovq32pmegqDDu1A47+AuwfE7zcuI4J0JprHuXns3jKSbHheWV9Sm10FWmU= =UxOr -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D290A7DA-0AED-4810-A1B1-470E35542292>