Date: Mon, 28 Sep 2015 21:30:40 -0700 From: Jason Schulz <schulz.j@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: Konstantin Belousov <kostikbel@gmail.com>, freebsd-threads@freebsd.org Subject: Re: pthread_getaffinity_np issue Message-ID: <20150929043040.GA2177@gmail.com> In-Reply-To: <5496698.OIvuy2PFgu@ralph.baldwin.cx> References: <20150924181127.GC3104@gmail.com> <20150924191121.GG3104@gmail.com> <20150924192623.GL67105@kib.kiev.ua> <5496698.OIvuy2PFgu@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 25, 2015 at 09:37:55AM -0700, John Baldwin wrote: > On Thursday, September 24, 2015 10:26:23 PM Konstantin Belousov wrote: > > So your issue only appears when you specify _XOPEN_SOURCE. This is reasonable, > > because __bitcount stuff in sys/types.h was put under _BSD_VISIBLE protection. > > I am not sure why and I Cc:ed the author of the change. > > > > IMO all symbols from __bitcount* are in the private namespace and could > > be made unconditionally accessible, to avoid surprises. I put the patch > > at the end of the message which does this. > > It was not on purpose, more to put it in the section with other "doodads". > If it is safe to move out from under BSD_VISIBLE then your patch is fine > with me. The only person I can think to ask would be bde@, but my guess > is your change is correct. > > -- > John Baldwin I tried the patch with _XOPEN_SOURCE=700 and the non-posix CPU_COUNT macro does compile correctly now. I didn't try with _POSIX_SOURCE, but I would guess it should also compile. If anyone wants me to test anything else with the patch, just let me know. -J
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150929043040.GA2177>