Date: Sun, 31 Jul 2016 20:36:47 -0500 From: Larry Rosenman <ler@lerctr.org> To: Adrian Chadd <adrian.chadd@gmail.com> Cc: Imre Vad??sz <ivadasz@freebsd.org>, Andriy Voskoboinyk <avos@freebsd.org>, "freebsd-wireless@freebsd.org" <freebsd-wireless@freebsd.org>, freebsd-current <freebsd-current@freebsd.org>, owner-freebsd-current@freebsd.org Subject: Re: IWM(7260), no connect Message-ID: <20160801013647.GA1294@pita> In-Reply-To: <CAJ-VmomUESXEjT3qS=b8HowrLsASwFAJ3DdOntuDtNoB6y9vMw@mail.gmail.com> References: <20160728023954.GA1321@pita> <op.ylazvgss4dikkl@localhost> <20160728233504.GA1226@pita> <CAJ-VmokWiaJLJQA6EW0ek2gLgeC8N=dGq5GHJo=WGoFa1w0b9w@mail.gmail.com> <4ee03d28cc2711ed9bc56a725cac344a@thebighonker.lerctr.org> <CAJ-VmomUESXEjT3qS=b8HowrLsASwFAJ3DdOntuDtNoB6y9vMw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Even with that reverted, I'm still having iffy connections.
Current code:
FreeBSD pita 12.0-CURRENT FreeBSD 12.0-CURRENT #4 r303597M: Sun Jul 31 16:02:39 CDT 2016 root@pita:/usr/obj/usr/src/sys/IWM-DEBUG amd64 1200001 1200001
Current diff to that SVN Rev:
Index: sys/dev/iwm/if_iwm.c
===================================================================
--- sys/dev/iwm/if_iwm.c (revision 303597)
+++ sys/dev/iwm/if_iwm.c (working copy)
@@ -3357,15 +3357,12 @@
uint8_t subtype = wh->i_fc[0] & IEEE80211_FC0_SUBTYPE_MASK;
if (subtype == IEEE80211_FC0_SUBTYPE_ASSOC_REQ ||
- subtype == IEEE80211_FC0_SUBTYPE_REASSOC_REQ) {
- tx->pm_frame_timeout = htole16(IWM_PM_FRAME_ASSOC);
- } else if (subtype == IEEE80211_FC0_SUBTYPE_ACTION) {
- tx->pm_frame_timeout = htole16(IWM_PM_FRAME_NONE);
- } else {
- tx->pm_frame_timeout = htole16(IWM_PM_FRAME_MGMT);
- }
+ subtype == IEEE80211_FC0_SUBTYPE_REASSOC_REQ)
+ tx->pm_frame_timeout = htole16(3);
+ else
+ tx->pm_frame_timeout = htole16(2);
} else {
- tx->pm_frame_timeout = htole16(IWM_PM_FRAME_NONE);
+ tx->pm_frame_timeout = htole16(0);
}
if (hdrlen & 3) {
Index: sys/dev/iwm/if_iwmreg.h
===================================================================
--- sys/dev/iwm/if_iwmreg.h (revision 303597)
+++ sys/dev/iwm/if_iwmreg.h (working copy)
@@ -4244,18 +4244,6 @@
IWM_TX_CMD_FLG_HCCA_CHUNK = (1 << 31)
}; /* IWM_TX_FLAGS_BITS_API_S_VER_1 */
-/**
- * enum iwm_tx_pm_timeouts - pm timeout values in TX command
- * @IWM_PM_FRAME_NONE: no need to suspend sleep mode
- * @IWM_PM_FRAME_MGMT: fw suspend sleep mode for 100TU
- * @IWM_PM_FRAME_ASSOC: fw suspend sleep mode for 10sec
- */
-enum iwm_tx_pm_timeouts {
- IWM_PM_FRAME_NONE = 0,
- IWM_PM_FRAME_MGMT = 2,
- IWM_PM_FRAME_ASSOC = 3,
-};
-
/*
* TX command security control
*/
Scan Debug:
http://www.lerctr.org/~ler/FreeBSD/WIFI-Scan.txt
What next?
On Thu, Jul 28, 2016 at 06:06:47PM -0700, Adrian Chadd wrote:
> +imre,
>
> Hi! Larry is having issues with r303418. Would you be able to help him out?
>
> (If it's not too bad, can we back this out until you figure out what's
> going on?)
>
> Thanks!
>
>
> -a
>
>
> On 28 July 2016 at 18:05, Larry Rosenman <ler@lerctr.org> wrote:
> > On 2016-07-28 20:02, Adrian Chadd wrote:
> >>
> >> Hi,
> >>
> >> Which commit(s) did you revert?
> >>
> >>
> >>
> >> -a
> >
> >
> > revert r303418
> >
> > and now it connects again.
> >
> >
> > --
> > Larry Rosenman http://www.lerctr.org/~ler
> > Phone: +1 214-642-9640 E-Mail: ler@lerctr.org
> > US Mail: 17716 Limpia Crk, Round Rock, TX 78664-7281
--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 214-642-9640 E-Mail: ler@lerctr.org
US Mail: 17716 Limpia Crk, Round Rock, TX 78664-7281
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160801013647.GA1294>