Date: Sat, 04 Nov 2017 01:16:57 +0000
From: bugzilla-noreply@freebsd.org
To: freebsd-java@FreeBSD.org
Subject: [Bug 220737] Mk/bsd.java.mk: Strict JAVA_{VERSION,VENDOR,ERROR} validation
Message-ID: <bug-220737-12-aW0e8N7zft@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-220737-12@https.bugs.freebsd.org/bugzilla/>
References: <bug-220737-12@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220737 --- Comment #5 from commit-hook@freebsd.org --- A commit references this bug: Author: kevans Date: Sat Nov 4 01:16:32 UTC 2017 New revision: 453438 URL: https://svnweb.freebsd.org/changeset/ports/453438 Log: Mk/bsd.java.mk: Strict JAVA_{VERSION,VENDOR,ERROR} validation Currently, validation of JAVA_{VERSION,VENDOR,ERROR} does not constitute an error and make(1) will happily continue, potentially doing the wrong thing. Adjust the behavior as follows: - Only validate each var if it's defined - Remain verbose about what error exists and what's expected - Fail the build if validation fails bsd.java.mk exhibited this behavior up until r217132 inadvertently changed it to be non-fatal. PR: 220737 Approved by: portmgr (bdrewery) Changes: head/Mk/bsd.java.mk -- You are receiving this mail because: You are on the CC list for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-220737-12-aW0e8N7zft>