Date: Mon, 3 Jul 2017 02:18:10 +0000 (UTC) From: Xin LI <delphij@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org Subject: svn commit: r320583 - stable/9/lib/libc/rpc Message-ID: <201707030218.v632IAbe033887@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: delphij Date: Mon Jul 3 02:18:10 2017 New Revision: 320583 URL: https://svnweb.freebsd.org/changeset/base/320583 Log: MFC r320494: Fix double free by reverting r300385 and r300624 which was false positive reported by cppcheck. Modified: stable/9/lib/libc/rpc/getnetconfig.c Directory Properties: stable/9/lib/libc/ (props changed) Modified: stable/9/lib/libc/rpc/getnetconfig.c ============================================================================== --- stable/9/lib/libc/rpc/getnetconfig.c Mon Jul 3 02:14:42 2017 (r320582) +++ stable/9/lib/libc/rpc/getnetconfig.c Mon Jul 3 02:18:10 2017 (r320583) @@ -697,7 +697,7 @@ dup_ncp(ncp) struct netconfig *ncp; { struct netconfig *p; - char *tmp, *tmp2; + char *tmp; u_int i; if ((tmp=malloc(MAXNETCONFIGLINE)) == NULL) @@ -706,7 +706,6 @@ struct netconfig *ncp; free(tmp); return(NULL); } - tmp2 = tmp; /* * First we dup all the data from matched netconfig buffer. Then we * adjust some of the member pointer to a pre-allocated buffer where @@ -728,7 +727,6 @@ struct netconfig *ncp; if (p->nc_lookups == NULL) { free(p->nc_netid); free(p); - free(tmp2); return(NULL); } for (i=0; i < p->nc_nlookups; i++) {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201707030218.v632IAbe033887>