Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 11 Feb 2018 10:26:15 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-pf@FreeBSD.org
Subject:   [Bug 209475] pf didn't check if enough free RAM for net.pf.states_hashsize
Message-ID:  <bug-209475-17777-dgQlEkcmga@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-209475-17777@https.bugs.freebsd.org/bugzilla/>
References:  <bug-209475-17777@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209475

--- Comment #27 from Kristof Provost <kp@freebsd.org> ---
(In reply to fehmi noyan isi from comment #26)
Yes, your analysis looks to be correct. I'd go for the second option: try to
allocate both keyhash and idhash with the requested size. If either one fai=
ls
free both and re-try with the default size.

I don't think the sizes of the structs are relevant here. We allocate
'pf_hashsize' elements of both, but we don't care how much memory each
allocation takes, just that we know how many there are.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-209475-17777-dgQlEkcmga>