Date: Sun, 27 May 2018 06:09:17 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Mark Felder <feld@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334221 - head/etc Message-ID: <20180527060917.GA3179@FreeBSD.org> In-Reply-To: <201805251936.w4PJaQIf093393@repo.freebsd.org> References: <201805251936.w4PJaQIf093393@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 25, 2018 at 07:36:26PM +0000, Mark Felder wrote: > New Revision: 334221 > URL: https://svnweb.freebsd.org/changeset/base/334221 > > Log: > rc.subr: Support loading environmental variables from a file > > + if [ -n "$_env_file" ] && [ -r "${_env_file}" ]; then Style bug: "$_env_file" vs. "${_env_file}". Also, isn't the -n check redundant? > + set -a > + . $_env_file Shouldn't it be quoted here as well (. "$_env_file")? ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180527060917.GA3179>