Date: Sun, 23 Jun 2019 02:46:39 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 210537] [patch] [feature request] set MIME type in cron-generated e-mails Message-ID: <bug-210537-227-Dj2o2EuDwU@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-210537-227@https.bugs.freebsd.org/bugzilla/> References: <bug-210537-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210537 --- Comment #26 from Eugene Grosbein <eugen@freebsd.org> --- (In reply to Mikhail Teterin from comment #25) The patch still has multiple issues: - cron.8 part is corrupted, please check it out carefully; - the change for usage() function still has the bug I already noted: it add= s -m instead of right -M; - the change still does not respect WITHOUT_FILE build option that is requi= red for CDDL-clean build of the system. Also, while increasing WARNS is good intention, such style changes should n= ot be mixed with functional additions like yours. Please split the change in t= wo, one for your own code and second for a patch touching other parts of code j= ust fixing warnings. Among other things, it will make code review easier. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-210537-227-Dj2o2EuDwU>