Date: Sat, 14 Nov 2020 17:27:17 -0800 From: Douglas Thrift <douglaswth@gmail.com> To: ports@FreeBSD.org, woodsb02@FreeBSD.org Subject: Re: FreeBSD Port: dhcpcd-9.3.2 Message-ID: <47064bf7-148c-dfa1-5ee2-2eda430ab260@gmail.com> In-Reply-To: <74b8e972-0f06-8fa0-01ba-9a22207197a7@marples.name> References: <8f21b571-a4d2-ad5d-b4b7-3e36436fa018@gmail.com> <001301d63ca6$d5ddaa00$8198fe00$@gmail.com> <74b8e972-0f06-8fa0-01ba-9a22207197a7@marples.name>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------DEA2A33DEB4EC952F7D4A610 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit On 6/7/2020 2:39 AM, Roy Marples wrote: > On 07/06/2020 09:37, driesm.michiels@gmail.com wrote: >>> stop the previous dhcpcd manually and then I discovered that the >>> `pidfile` >>> was still incorrect: >>> >>> pidfile="/var/run/dhcpcd/dhcpcd-$ifn.pid" >>> >>> should actually be: >>> >>> pidfile="/var/run/dhcpcd/$ifn.pid" > > pidfile=$(dhcpcd -P $args) > > dhcpcd -4 em0 > dhcpcd -6 em0 > > Give different pidfiles. > >> It has already been committed to master and should be fixed in the new >> dhcpcd-9.1.1 release. > > This patch is also relevant for FreeBSD: > https://roy.marples.name/cgit/dhcpcd.git/commit/?id=24019cdbe66a152a1e9936ad5c7ae1657713ef2c > > > Roy It seems like dhcpcd-9.3.2 is working fine for me now in FreeBSD 12.2. I have attached a patch for the rc.d script for when it is run against an interface which matches Roy's suggestion. -- Douglas William Thrift <https://douglasthrift.net/>; --------------DEA2A33DEB4EC952F7D4A610 Content-Type: text/plain; charset=UTF-8; name="dhcpcd-9.3.2.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="dhcpcd-9.3.2.diff" Index: files/dhcpcd.in =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- files/dhcpcd.in (revision 555156) +++ files/dhcpcd.in (working copy) @@ -16,7 +16,7 @@ if [ -z "$flags" -a -n "$specific" ]; then rc_flags=3D"$specific" fi - pidfile=3D"/var/run/dhcpcd/dhcpcd-$ifn.pid" + pidfile=3D"$($command -P $rc_flags $ifn)" else pidfile=3D"$($command -P $rc_flags)" : ${dhcpcd_enable:=3DNO} --------------DEA2A33DEB4EC952F7D4A610--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47064bf7-148c-dfa1-5ee2-2eda430ab260>