Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 11 Oct 2021 09:15:44 GMT
From:      Mateusz Guzik <mjg@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: e1df0f5dbf59 - stable/13 - vfs: retire VNODE_REFCOUNT_FENCE_* macros
Message-ID:  <202110110915.19B9Fi4g009379@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by mjg:

URL: https://cgit.FreeBSD.org/src/commit/?id=e1df0f5dbf591a62b81073cfa523d91477468376

commit e1df0f5dbf591a62b81073cfa523d91477468376
Author:     Mateusz Guzik <mjg@FreeBSD.org>
AuthorDate: 2021-09-18 08:14:35 +0000
Commit:     Mateusz Guzik <mjg@FreeBSD.org>
CommitDate: 2021-10-11 09:09:35 +0000

    vfs: retire VNODE_REFCOUNT_FENCE_* macros
    
    They are unused as of last year.
    
    (cherry picked from commit 5d8e32a66c1700323c570d25b03672f35f4e0110)
---
 sys/kern/vfs_subr.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c
index d67936447216..9d0638d1bf38 100644
--- a/sys/kern/vfs_subr.c
+++ b/sys/kern/vfs_subr.c
@@ -120,22 +120,6 @@ static int	v_inval_buf_range_locked(struct vnode *vp, struct bufobj *bo,
 		    daddr_t startlbn, daddr_t endlbn);
 static void	vnlru_recalc(void);
 
-/*
- * These fences are intended for cases where some synchronization is
- * needed between access of v_iflags and lockless vnode refcount (v_holdcnt
- * and v_usecount) updates.  Access to v_iflags is generally synchronized
- * by the interlock, but we have some internal assertions that check vnode
- * flags without acquiring the lock.  Thus, these fences are INVARIANTS-only
- * for now.
- */
-#ifdef INVARIANTS
-#define	VNODE_REFCOUNT_FENCE_ACQ()	atomic_thread_fence_acq()
-#define	VNODE_REFCOUNT_FENCE_REL()	atomic_thread_fence_rel()
-#else
-#define	VNODE_REFCOUNT_FENCE_ACQ()
-#define	VNODE_REFCOUNT_FENCE_REL()
-#endif
-
 /*
  * Number of vnodes in existence.  Increased whenever getnewvnode()
  * allocates a new vnode, decreased in vdropl() for VIRF_DOOMED vnode.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202110110915.19B9Fi4g009379>