Date: Sun, 31 Oct 2021 22:26:38 -0400 From: "Kevin P. Neal" <kpn@neutralgood.org> To: Emmanuel Vadot <manu@bidouilliste.com> Cc: Benjamin Kaduk <bjkfbsd@gmail.com>, "Rodney W. Grimes" <rgrimes@freebsd.org>, "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>, gljennjohn@gmail.com, Gleb Smirnoff <glebius@freebsd.org>, Slawa Olhovchenkov <slw@zxy.spb.ru>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 225639e7db68 - main - vt: Disable bell by default Message-ID: <YX9QXlQVJvFTc2y4@neutralgood.org> In-Reply-To: <20211022225540.a4220cfddc96cc1e08cb5235@bidouilliste.com> References: <20211021192020.6dcb95c1@ernst.home> <202110221704.19MH4FDn075994@gndrsh.dnsmgr.net> <20211022194717.8c94d2fa302339b55882497f@bidouilliste.com> <CAJ5_RoC8jtwPrTmuEWGvBNzieJRttvR4BzAY5LFYovZg4pu=2w@mail.gmail.com> <20211022225540.a4220cfddc96cc1e08cb5235@bidouilliste.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Oct 22, 2021 at 10:55:40PM +0200, Emmanuel Vadot wrote: > If I knew that this change would have caused that much mails I would > have send a mail to current or whatever before and left the review > opened for more time. Is this exposing an issue with the review process? I don't know the FreeBSD review process, but I do know the LLVM one. Now, LLVM has a different set of people in the project. That means that what works over there might not be a good fit here. I thought I'd mention it just the same. On the LLVM project they don't allow code that is up for review to be pushed without an explicit signoff from one of the reviewers. Period. There's _no_ putting code up for review, waiting, and then going ahead and pushing. If there's no feedback for a while the person asking for the review will add a message every week or two that says just "ping". This often nudges people to get to the review. Not always, and it can take a while to get code through, but that's the process. Changes are allowed without a review if they are "obvious". If someone pushes a change that another committer doesn't feel is obvious then the change is reverted, usually by the person who cares. Personally, I've never had this happen, but my non-review pushes are usually either new tests or fixes to broken builds. -- Kevin P. Neal http://www.pobox.com/~kpn/ "It sounded pretty good, but it's hard to tell how it will work out in practice." -- Dennis Ritchie, ~1977, "Summary of a DEC 32-bit machine"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YX9QXlQVJvFTc2y4>