Date: Sun, 02 May 2021 01:56:04 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 255523] vn_generic_copy_file_range copies holes to EOF slowly Message-ID: <bug-255523-227-mN5OjtowKg@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-255523-227@https.bugs.freebsd.org/bugzilla/> References: <bug-255523-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255523 Rick Macklem <rmacklem@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #224599|0 |1 is obsolete| | Assignee|bugs@FreeBSD.org |rmacklem@FreeBSD.org --- Comment #5 from Rick Macklem <rmacklem@FreeBSD.org> --- Created attachment 224603 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D224603&action= =3Dedit add support for a hole to eof to vn_generic_copy_range() Update patch as suggested by asomers@. Moving the VOP_GETATTR() is actually a fix, since "goto out;" assumes an unlocked invp. It also is slightly optimized, since the inva are only needed if holein > 0. I moved the initialization of holetoeof to above the loop, since it easier to spot there (and I thoght style(9) frowned on initializations in declarations). No semntics change unless VOP_GETATTR() fails for some reason. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-255523-227-mN5OjtowKg>