Date: Sun, 07 Mar 2021 06:30:01 +0000 From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 250671] error reporting with bhyvectl could be improved Message-ID: <bug-250671-27103-jrWlUpY5qD@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-250671-27103@https.bugs.freebsd.org/bugzilla/> References: <bug-250671-27103@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D250671 --- Comment #2 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D6bb140e3ca895a148f32c93d50f93619b= f735f73 commit 6bb140e3ca895a148f32c93d50f93619bf735f73 Author: Robert Wing <rew@FreeBSD.org> AuthorDate: 2021-03-07 06:19:30 +0000 Commit: Robert Wing <rew@FreeBSD.org> CommitDate: 2021-03-07 06:19:30 +0000 bhyvectl: print a better error message when vm_open() fails Use errno to print a more descriptive error message when vm_open() fails libvmm: preserve errno when vm_device_open() fails vm_destroy() squashes errno by making a dive into sysctlbyname() - we can safely skip vm_destroy() here since it's not doing any critical clean up at this point. Replace vm_destroy() with a free() call. PR: 250671 MFC after: 3 days Submitted by: marko@apache.org Reviewed by: grehan Differential Revision: https://reviews.freebsd.org/D29109 lib/libvmmapi/vmmapi.c | 2 +- usr.sbin/bhyvectl/bhyvectl.c | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-250671-27103-jrWlUpY5qD>