Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 20 May 2023 21:37:32 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 162373] VESA framebuffer memory mapping fails with EINVAL for certain modes
Message-ID:  <bug-162373-227-WAiInXhyT5@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-162373-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-162373-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D162373

Jonathan de Boyne Pollard <J.deBoynePollard-newsgroups@NTLWorld.COM> change=
d:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |J.deBoynePollard-newsgroups
                   |                            |@NTLWorld.COM

--- Comment #3 from Jonathan de Boyne Pollard <J.deBoynePollard-newsgroups@=
NTLWorld.COM> ---
This affects more than just 1 person.

The suggested fix isn't quite right.  The simplest fix is to just take the =
"-
PAGE_SIZE" out.  The page maps are set up to cover the whole buffer, in fac=
t to
cover the largest buffer size in any VESA mode, and va_window_size is the r=
ight
field to use.

There's a similar check, with a similar query, in the VGA driver.  That's n=
ever
been questioned probably because the VGA memory windows are usually a whole
multiple of the page size.

Applications programs have been working around this for years by rounding
va_window_size down to the next lower whole multiple of the page size.  But
this is at the expense of their being unable to memory map a number of pixel
rows at the bottom of the screen.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-162373-227-WAiInXhyT5>